Skip to content

feat: Use stubtest to verify stub correctness - #30

Merged
smarie merged 1 commit into
smarie:mainfrom
last-partizan:22-stubtest
Jul 6, 2022
Merged

smarie merged 1 commit into
smarie:mainfrom
last-partizan:22-stubtest

Conversation

@last-partizan

@last-partizan last-partizan commented Jul 2, 2022 •

Copy link
Copy Markdown
Contributor

Here's my first attempt to add stubgen to verify stub correctness.

Right now it's failing with nox, but works fine if i use it with normal venv.

It works!

Comment thread noxfile.py Resolved
@last-partizan
last-partizan force-pushed the 22-stubtest branch 3 times, most recently from 3d52dc4 to abc0a47 Compare July 6, 2022 14:50
Comment thread .github/workflows/base.yml Resolved
- name: Install conda v3.7
uses: conda-incubator/setup-miniconda@v2
with:
python-version: '3.10'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, stubtest cannot handle try/except imports, so i'm using Python 3.10 here.

@smarie smarie Jul 6, 2022 •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the version used for the tests, this is the version used to execute nox. So 3.7 should be fine too, but of course any will do

@last-partizan
last-partizan marked this pull request as ready for review July 6, 2022 14:56
@last-partizan
last-partizan requested a review from smarie July 6, 2022 14:56
@smarie

smarie commented Jul 6, 2022

Copy link
Copy Markdown
Owner

Nice PR, thanks a lot @last-partizan !

@smarie
smarie merged commit b39aeb2 into smarie:main Jul 6, 2022
@last-partizan
last-partizan deleted the 22-stubtest branch July 6, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants