Skip to content

Add ISO section key - #46

Merged
soffes merged 1 commit into
soffes:mainfrom
irth:main
Dec 29, 2024
Merged

soffes merged 1 commit into
soffes:mainfrom
irth:main

Conversation

@irth

@irth irth commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

support for the § key on ISO keyboards :)

@irth irth changed the title Add ISO section Add ISO section key Jun 7, 2024
@envomer

envomer commented Dec 29, 2024

Copy link
Copy Markdown

@soffes Can we get this merged? Thanks ahead ^^

@irth Thanks for this MR!

@soffes soffes left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I don't have an ISO keyboard so this never crossed my mind!

Happy to merge after a minor style nit :)

Comment thread Sources/HotKey/Key.swift
case "rightarrow", "→": self = .rightArrow
case "downarrow", "↓": self = .downArrow
case "uparrow", "↑": self = .upArrow
case "section", "§": self = .section

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind fixing the indentation on 264, 384, and 504 to match the others around it?

@soffes

soffes commented Dec 29, 2024

Copy link
Copy Markdown
Owner

Oh realizing this is an old PR. Will go ahead and merge

@soffes
soffes merged commit 9588de6 into soffes:main Dec 29, 2024
@soffes

soffes commented Dec 29, 2024

Copy link
Copy Markdown
Owner

Released in version 0.2.1

@envomer

envomer commented Dec 29, 2024

Copy link
Copy Markdown

Thank you very much 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants