Repository navigation
Change "bubbles" to "bubble" - #675
Merged
Merged
Conversation
**Change "bubbles" to "bubble"** - from: dispatch events to the relevant elements as they bubbles up. - to: dispatch events to the relevant elements as they bubble up. **dispatch events** "In this method event listeners are attached to the `document` element, and dispatch events to the relevant elements as they bubbles up." This is unclear to me. Is "dispatch events" is a thing/noun which I have not heard of? Otherwise, it could be saying: - ... event listeners are attached to the `document` element, and dispatch**ed** to the relevant elements ...
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LadyBluenotes
approved these changes
Apr 13, 2024
ryansolid
added a commit
that referenced
this pull request
Oct 15, 2026
…1653) * reference: regenerate against solid next eb4e0192; dispositions for rc.14-rc.15 exports New pages: markRaw, onHydrationEnd, dispatchAsInteraction. dynamicComponent, lazyModule and reportRequestFailure join the dynamic, lazy and configureServerErrors pages; ssrStyleProperties is compiler ABI and hidden. The NoArray brand on the seedless derived-store form is dropped from rendered signatures. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y4HXPRqXPnqriNxDyin6eK * docs: catch up hand-written pages with solid rc.14-next and router next.34-next.40 Solid: seedless derived stores and complete seeds (#4073); storePath recipes become draft setters (#4053); respond() envelope and non-JSON bodies; performance-tracks defaults; kind "request" and reportRequestFailure; lowercase on* migration note; dynamicComponent, lazyModule and onHydrationEnd mentions. Router: link preloading is opt-in (preloadLinks strategies); data-pending needs pendingLinks; aria-current matches path and query; decoded params (#681); useInRouter (#675); action settle timing; liveQuery reference; anchor attributes typed by the router. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y4HXPRqXPnqriNxDyin6eK * docs(router): say held update, not transition, per the Solid Terms table Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y4HXPRqXPnqriNxDyin6eK --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change "bubbles" to "bubble"
dispatch events
"In this method event listeners are attached to the
documentelement, and dispatch events to the relevant elements as they bubbles up."This is unclear to me. Is "dispatch events" a thing/noun or is the wording wrong?
Perhaps it should be:
documentelement, and dispatched to the relevant elements ...