Repository navigation
Require solid-js / @solidjs/web 2.0.0-rc.15 - #676
Merged
Merged
Conversation
Moves the dev deps, lockfile and peer floor to rc.15 and updates the tests that relied on rc.14 behaviour: - claimElement is once per element since solidjs/solid#3924, so tests that simulate a morph re-claim now call claimElementTree (the sweep frames use), and the href re-claim test writes href through the compiler-owned setAttribute. - respond() is typed as its value and redirect() defaults to never (solidjs/solid#3910), so two server specs and one hash-history spec annotate the Response they use. - The #655 characterization's superseded-navigation timeline now lists data-pending attribute writes before the useLinkState render effects in the same flush, matching the single-navigation ordering. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R2FCNsvaipU3xXx9p83VUs
🦋 Changeset detectedLatest commit: 5729e79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
Before: the router builds and tests against
solid-js/@solidjs/web2.0.0-rc.14. Moving the lockfile to the published rc.15 fails 6 vitest tests and 3 type checks. #669 and #668 are drafts waiting on APIs that only exist in rc.15.After: the dev deps, lockfile and peer floor are on
^2.0.0-rc.15, andpnpm testpasses (612 client, 88 server, types). #669 and #668 can rebase onto this.No
src/changes were needed. Every failure was a test relying on rc.14 behaviour:claimElementa once-per-element mount claim. Tests that simulate a morph by stripping attributes and callingclaimElementagain now callclaimElementTree, which is the sweep frames actually use for re-claims. The viewport-preload "href re-claim" test now writeshrefthrough the compiler-ownedsetAttribute, which is the real re-claim path.respond(value)as its value, andredirect()defaults tonever. Two server specs and one hash-history spec now annotate theResponsethey use. Runtime behaviour is unchanged.data-pendingattribute writes now come before theuseLinkStaterender effects within the same flush. This matches the single-navigation scenario's ordering. The checkpoint states are unchanged.There's also a patch changeset noting the rc.15 requirement and claim contract.
🤖 Generated with Claude Code
https://claude.ai/code/session_01R2FCNsvaipU3xXx9p83VUs
Generated by Claude Code