Skip to content

e-stepper: arrows to frames only on hover; to objects on hover unless "From program" is on - #174

Merged
martin-henz merged 1 commit into
mainfrom
estepper-hover-arrows
Oct 13, 2026
Merged

martin-henz merged 1 commit into
mainfrom
estepper-hover-arrows

Conversation

@martin-henz

@martin-henz martin-henz commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Agreed with @sayomaki (SA@NUS feedback):

  • An arrow from the program to a frame (environment references) is drawn only while the frame is hovered.
  • An arrow to an object (compound value references) is drawn only while the object is hovered when "From program" is off, and all the time when it is on.

Protocol: onAnchors(resolve, fromProgram?) gets a second argument. A host that omits it behaves as before (it only called onAnchors with a resolver while "From program" was on, and with null otherwise). The frontend needs a matching change to keep the anchors while "From program" is off and pass fromProgram=false; until then, with the filter off there are no arrows at all, as today.

Tests: vitest (e-stepper 83, all 315). tsc shows an error at ProgramArrows.tsx (scale on CseDiagramPoint) that is already on main.

🤖 Generated with Claude Code

…hover unless "From program" is on

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8d3e768

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@martin-henz

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T23:22:00.598661Z 8d3e768 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 8d3e768fb0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@martin-henz
martin-henz merged commit ea49dc1 into main Oct 13, 2026
2 checks passed
@martin-henz
martin-henz deleted the estepper-hover-arrows branch October 13, 2026 23:25
martin-henz added a commit that referenced this pull request Oct 13, 2026
…othing deployed (#175)

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant