Skip to content

database needs to be changed to db #32

Closed
Closed
database needs to be changed to db#32

Description

@kjellouli
kjellouli
opened on Sep 14, 2019

Can't connect to redis, it results in ERR invalid db index. database in redis.datasource.ts needs to be changed to db in line:

loopback4-starter/src/datasources/redis.datasource.ts

Line 17 in e76d8d7

database: process.env.REDIS_DATABASE,

as per:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/f574f4aa1344774ef08caf8c9e2f994c4e7fa30e/types/ioredis/index.d.ts#L948

Activity

  1. samarpan-b commented on Sep 16, 2019

    @samarpan-b
    samarpan-b
    on Sep 16, 2019
    Contributor

    Thanks for the update @kjellouli . Would you mind raising a PR for this ? I can merge it then.

  2. kjellouli commented on Sep 17, 2019

    @kjellouli
    kjellouli
    on Sep 17, 2019
    ContributorAuthor

    #34

  3. samarpan-b commented on Sep 26, 2019

    @samarpan-b
    samarpan-b
    on Sep 26, 2019
    Contributor

    Merged

  4. samarpan-b
    closed this as completedon Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions