DefaultUserModifyCrudRepository not setting properly created_by #84

Activity

1. akshatdubeysf commented on Apr 20, 2021

   

   akshatdubeysf

   on Apr 20, 2021

   Last edited by akshatdubeysf

   Contributor

   More actions

   Hi @dkmanolov,

   If I understood it correctly, your issue is that you are not getting the current user_tenant id as uuid in CurrentUser? For that you would have to change the Tenant model, and make appropriate changes in the DB accordingly, if you are getting any issues doing that, please share them here, preferably with a screenshot of any error you are facing. After doing all this, you would still need to generate a new token to get the changes in the CurrentUser binding.
2. dkmanolov commented on Apr 20, 2021

   

   dkmanolov

   on Apr 20, 2021

   Last edited by dkmanolov

   Author

   More actions

   Hi @akshatdubeysf, thank's for your reply. I'll try to provide more detail info about the case.
   The problem is that when I try to create for example a new tenant, I'm getting:
   Request POST /tenants failed with status code 500. error: insert or update on table "tenants" violates foreign key constraint "fk_created_by"

   When I debug, I saw that in DefaultUserModifyCrudRepository in create method I have this:

   async create(entity: DataObject<T>, options?: Options): Promise<T> {
       const currentUser = await this.getCurrentUser();
       if (!currentUser) {
         throw new HttpErrors.Forbidden(AuthErrorKeys.InvalidCredentials);
       }
   
       entity.createdBy = currentUser.id;
       entity.modifiedBy = currentUser.id;
   
       return super.create(entity, options);
     }
   

   And if I console log currentUser.id shows the id from the users table.
   But according to the migrations here user_tanants id is expected so that's why I'm getting such error.

   I don't think this is related to the uuid transition, I've noticed it then because when I've tested with just single user and signle row in user_tenants they both have id of 1, but with uuid every id is unique and the error appear.
3. akshatdubeysf commented on Apr 22, 2021

   

   akshatdubeysf

   on Apr 22, 2021

   Contributor

   More actions

   Thanks for you detailed response, it is indeed an issue, I'll try and raise a PR to fix this as soon as possible.
4. dkmanolov commented on Apr 22, 2021

   

   dkmanolov

   on Apr 22, 2021

   Author

   More actions

   No problem thank you for your time!

   My quick fix was to extend the AuthUser model with userTenantId and use it later where needed (in the DefaultUserModifyCrudRepository).

   entity.createdBy = currentUser.userTenantId;
5. samarpan-b

   closed this as completedin #86on May 20, 2021