Repository navigation
test(apply): run the simulated client from a script, not a renamed sleep - #4049
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust workflow's ubuntu-latest job now fails on every run that triggers it.
ubuntu-latestmoved from Ubuntu 24.04 to 26.04, which ships uutils coreutils.unwritable_installation_does_not_stop_spotify_or_change_its_archivesimulates the Spotify client by copying/bin/sleeptospa<pid>. On 26.04,/bin/sleepresolves to the uutils multicall binary, which picks the utility from its own name. The renamed copy exits at once withcoreutils: unknown program 'spa10624', and the test fails on "process lookup must observe the simulated client before Apply". The last greenv3-betarun, on a8d7f56, ran on ubuntu-24.04. #4048, which only changes the loader's JavaScript, fails here for this reason.The fixture is now a small
#!/bin/shscript namedspa<pid>. Linux names a script's process after the script, so thepgrep -xlookup the test relies on still finds it. Apply first probes the client with--version, which the copiedsleepanswered with its own version line. The script answers it by exiting with no output, so the version stays undetected as before. Otherwisedetect_versionwaits on a script that never exits.Testing
The test binaries were built in the
rustimage and run inubuntu:26.04as uid 1000, which has the uutils/bin/sleep. Every workspace test binary passes there: cli 1, completions 1, daemon 34, spicetify 156 (including this test), tui 5.cargo fmt --checkpasses.