[afonsojramos]

The ContextMenuV2.SubMenuItems doc and the ItemSubMenu.addItem and removeItem docs in globals.d.ts described an older implementation, where only a Set could change after construction. ItemSubMenu now copies the array or Set it is given, addItem appends and ignores an entry that is already present, and removeItem ignores an absent one. The docs now say that.

Testing

• The existing "renders items passed as a Set or an array" test now also checks that changing the passed collection after construction does not change the sub menu.
• node --test src/jsHelper/spicetifyWrapper/menus.test.mts and pnpm typecheck pass.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: spicetify/cli
• Branch: docs/submenu-items
• File: .coderabbit.yaml
• Commit: 4accf38
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: f680502e-c375-459f-b345-6022f3a616f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn