Skip to content

Allow overriding getScheme on DefaultServiceInstance. - #1168

Merged
OlgaMaciaszek merged 3 commits into
mainfrom
allow-overriding-getScheme
Nov 8, 2022
Merged

OlgaMaciaszek merged 3 commits into
mainfrom
allow-overriding-getScheme

Conversation

@OlgaMaciaszek

Copy link
Copy Markdown
Collaborator

Fixes gh-823.

String scheme = this.uri.getScheme();
if ("https".equals(scheme)) {
scheme = this.uri.getScheme();
if (Arrays.asList("https", "wss").contains(scheme)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any concern on case?
I would make the list a class variable instead of creating it everytime setUri is called.

@OlgaMaciaszek
OlgaMaciaszek merged commit 5015b13 into main Nov 8, 2022
OlgaMaciaszek added a commit that referenced this pull request Nov 8, 2022

@ryanjbaxter ryanjbaxter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlgaMaciaszek
OlgaMaciaszek deleted the allow-overriding-getScheme branch November 13, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SimpleServcieInstance should override getScheme()

2 participants