Skip to content

Revisit dependency to Spring Messaging #1205

Open

Description

@fmbenhassine

Discussed in #1204

Originally posted by piotrooo November 1, 2025
I'd like to ask about the rationale for using spring-messaging in spring-shell. The only reason I can see is to reuse Message and HandlerMethodArgumentResolver as some kind of generic holder (?) for multiple purposes.

Is that really the best approach? It feels a bit bizarre.

Maybe a spring-shell specific HandlerMethodArgumentResolver should be introduced, and the dependency on spring-messaging could be dropped?

Activity

  1. fmbenhassine commented on Nov 2, 2025

    @fmbenhassine
    ContributorAuthor

    I couldn't agree more! I came to the same conclusion when I was reviewing dependencies (similar to having core depending on a ui module, see c95651a).. Same thing for reactor dependency, I see no added value of using it in the context of interactive shell applications (even in non interactive mode BTW, with all the complexity in DefaultEventLoop).

    Anyway, I will plan this for v4 and see if we can improve things with less dependencies.

  2. added and removed
    status/need-triageTeam needs to triage and take a first look
    on Nov 2, 2025
  3. added this to the 4.0.0 milestone on Nov 2, 2025
  4. modified the milestones: 4.0.0, 4.1.0 on Dec 26, 2025
  5. changed the title [-]The reason of Spring Messaging in Spring Shell[/-] [+]Revisit dependency to Spring Messaging[/+] on Apr 17, 2026
  6. removed this from the 4.1.0 milestone on Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions