Skip to content

SQLite upsert does not work #1728

Closed
#1732
Closed
SQLite upsert does not work#1728
#1732
Labels
📚 sqlite💻 linuxbugSomething isn't working

Description

@Elara6331
Elara6331
opened on Jul 7, 2022

Version

Other

What happened?

SQLite upsert syntax is not working using the beta SQLite engine from the latest main branch.

Relevant log output

mismatched input '=' expecting '=='

Database schema

CREATE TABLE IF NOT EXISTS locations (
    id              INTEGER PRIMARY KEY,
    name            TEXT    NOT NULL,
    address         TEXT    NOT NULL,
    zip_code        INT     NOT NULL,
    latitude        REAL    NOT NULL,
    longitude       REAL    NOT NULL,
    UNIQUE(name)
);

SQL queries

INSERT INTO locations (
    name,
    address,
    zip_code,
    latitude,
    longitude
)
VALUES (?, ?, ?, ?, ?)
ON CONFLICT(name) DO UPDATE SET 
    name = excluded.name,
    address = excluded.address
    zip_code = excluded.zip_code
    latitude = excluded.latitude
    longitude = excluded.longitude;

Configuration

No response

Playground URL

No response

What operating system are you using?

Linux

What database engines are you using?

No response

What type of code are you generating?

Go

Activity

  1. Elara6331
    added
    bugSomething isn't working
    triageNew issues that hasn't been reviewed
    on Jul 7, 2022
  2. kyleconroy
    added
    📚 sqlite
    💻 linux
    go
    and removed
    triageNew issues that hasn't been reviewed
    on Jul 10, 2022
  3. kyleconroy
    closed this as completedin #1732on Jul 10, 2022

  4. talksik commented on Mar 29, 2024

    @talksik
    talksik
    on Mar 29, 2024

    Still not working for me:

    -- name: UpsertUser :exec
INSERT INTO users (user_id, status)
VALUES (@userId, @newStatus)
ON CONFLICT (user_id) 
DO UPDATE SET status = @updatedStatus;

    Generated:

    const upsertUser = `-- name: UpsertUser :exec
INSERT INTO users (user_id, status)
VALUES (?1, ?2)
ON CONFLICT (user_id) 
DO UPDATE SET status = @updatedStatus
`

type UpsertUserParams struct {
	UserId    string
	NewStatus int64
}

func (q *Queries) UpsertUser(ctx context.Context, arg UpsertUserParams) error {
	_, err := q.db.ExecContext(ctx, upsertUser, arg.UserId, arg.NewStatus)
	return err
}

    The last arg is not being parsed.

    Tried updating sqlc as well: v1.26.0

  5. orisano commented on Mar 30, 2024

    @orisano
    orisano
    on Mar 30, 2024
    Contributor

    repro: https://play.sqlc.dev/p/815dd8823fdf9bbe30ca9f4c9a96f2511c165c90896af98a68c05f3584e69ec9

  6. talksik commented on Mar 30, 2024

    @talksik
    talksik
    on Mar 30, 2024

    Oh thank you @orisano ! Appreciate ya :)

  7. sztanpet commented on Jun 30, 2024

    @sztanpet
    sztanpet
    on Jun 30, 2024

    Still happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    📚 sqlite💻 linuxbugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions