Skip to content

To check if batch is closed if you need to return a pointer to the type the wrong code is generated #1959

Closed
#1960
Closed
To check if batch is closed if you need to return a pointer to the type the wrong code is generated#1959
#1960
Labels
📚 postgresql🔧 golangbugSomething isn't workingpgx/v4pgx/v5
Milestone
1.18.0

Description

@flymedllva
flymedllva
opened on Nov 19, 2022

Version

v1.16.0 or 3623ec8, version v1.15.0 has the correct behavior, since there is no batch closeness check

What happened?

To check if batch is closed if you need to return a pointer to the type the wrong code is generated

Screenshot 2022-11-19 at 17 39 42

SQL queries

:batchone

Configuration

version: "2"
engine: "postgresql"
sql_package: "pgx/v4"
emit_db_tags: true
emit_result_struct_pointers: true

What operating system are you using?

macOS

What database engines are you using?

PostgreSQL

What type of code are you generating?

Go

Activity

  1. flymedllva
    added
    bugSomething isn't working
    triageNew issues that hasn't been reviewed
    on Nov 19, 2022
  2. flymedllva
    added 2 commits that reference this issue on Nov 19, 2022

    fix: pgx closed batch return pointer if need sqlc-dev#1959

    bcd037a

    fix: pgx closed batch return pointer if need sqlc-dev#1959

    6eaf60c

  3. JordanP commented on Nov 21, 2022

    @JordanP
    JordanP
    on Nov 21, 2022
    Contributor

    Nothing really wrong in the original PR, it's just that the emit_result_struct_pointers feature flag did not exist when the PGXv5 support was originally submitted.

  4. JordanP commented on Nov 21, 2022

    @JordanP
    JordanP
    on Nov 21, 2022
    Contributor

    It certainly is a regression though,it probably means we moved "old" code to a new place.

  5. flymedllva commented on Nov 21, 2022

    @flymedllva
    flymedllva
    on Nov 21, 2022
    ContributorAuthor

    This flag was also for v4. Generally, with this flag there is an error in codogeneration

  6. thesiti92 commented on Jan 13, 2023

    @thesiti92
    thesiti92
    on Jan 13, 2023

    would be great to merge this :)

  7. flymedllva
    added 2 commits that reference this issue on Feb 14, 2023

    fix: pgx closed batch return pointer if need sqlc-dev#1959

    021a19b

    fix: pgx closed batch return pointer if need sqlc-dev#1959

    57ec36d
  8. kyleconroy
    added
    📚 postgresql
    🔧 golang
    pgx/v4
    pgx/v5
    and removed
    triageNew issues that hasn't been reviewed
    on Feb 22, 2023
  9. kyleconroy
    added this to the 1.18.0 milestone on Feb 22, 2023
  10. flymedllva
    added 2 commits that reference this issue on Feb 22, 2023

    fix: pgx closed batch return pointer if need sqlc-dev#1959

    1800c3f

    fix: pgx closed batch return pointer if need sqlc-dev#1959

    a8b5574
  11. kyleconroy
    closed this as completedin #1960on Feb 23, 2023
  12. kyleconroy
    added a commit that references this issue on Feb 23, 2023

    fix: pgx closed batch return pointer if need #1959 (#1960)

    c1c275b
  13. alfonsodev
    added a commit that references this issue on Oct 13, 2025

    fix: pgx closed batch return pointer if need sqlc-dev#1959 (sqlc-dev#…

    e6f775b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    📚 postgresql🔧 golangbugSomething isn't workingpgx/v4pgx/v5

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions