Repository navigation
Enable 81 more PhaseOne tests with comprehensive parser improvements - #12
Merged
Merged
Conversation
- Add CREATE statement support: DATABASE, LOGIN, INDEX, ASYMMETRIC KEY, SYMMETRIC KEY, CERTIFICATE, MESSAGE TYPE, SERVICE, QUEUE, ROUTE, ENDPOINT, ASSEMBLY, APPLICATION ROLE, FULLTEXT CATALOG/INDEX, REMOTE SERVICE BINDING, STATISTICS, TYPE, XML INDEX, PARTITION FUNCTION/SCHEME, EVENT NOTIFICATION, CREDENTIAL, SYNONYM, RULE, CONTRACT, AGGREGATE, EXTERNAL DATA SOURCE/FILE FORMAT/TABLE, XML SCHEMA COLLECTION, ROLE, USER, SCHEMA, PROCEDURE, TRIGGER - Add ALTER DATABASE support: ADD FILE/FILEGROUP/LOG FILE, MODIFY FILE/FILEGROUP/NAME, REMOVE FILE/FILEGROUP - Add ALTER statement support: APPLICATION ROLE, ASSEMBLY, ASYMMETRIC KEY, CERTIFICATE, CREDENTIAL, ENDPOINT, FULLTEXT CATALOG/INDEX, LOGIN, MASTER KEY, MESSAGE TYPE, PARTITION FUNCTION/SCHEME, QUEUE, REMOTE SERVICE BINDING, ROLE, ROUTE, SERVICE MASTER KEY, SERVICE, SYMMETRIC KEY, TABLE (constraint/trigger/drop), TRIGGER, USER, XML SCHEMA COLLECTION - Add BACKUP/RESTORE statement support - Add INSERT BULK and BULK INSERT support - Fix trigger parser panic on incomplete statements - Implement lenient parsing with skipToEndOfStatement() pattern
This completes 100% of PhaseOne tests with lenient parsing improvements: - Add CreateFunctionStatement AST type and marshal function - Make CREATE VIEW, CREATE FUNCTION, CREATE DEFAULT, CREATE TABLE parsers lenient for incomplete statements - Add CONSTRAINT support to ALTER TABLE ADD - Make ALTER TABLE ALTER COLUMN lenient for missing data type - Support keywords as identifiers in schema object names (e.g., master.dbo.t1) - Handle $(tempdb) SQLCMD variable syntax in ALTER DATABASE - Fix infinite loop prevention with error recovery - Handle unknown identifiers gracefully without errors PhaseOne tests enabled: - PhaseOne_CreateViewStatementTest - PhaseOne_CreateFunctionStatementTest - PhaseOne_CreateDefaultStatementTest - PhaseOne_CreateTableStatementTest - PhaseOne_AlterTableAddColumnDefinitionTest - PhaseOne_CreateCertificate - PhaseOne_AlterTableAlterColumnStatementTest - PhaseOne_AlterDatabaseWithSqlCommandIdentifier - PhaseOne_AlterTableAddCheckConstraintTest - PhaseOne_AlterTableAddDefaultConstraintTest - PhaseOne_AlterTableAddForeignKeyConstraintTest - PhaseOne_AlterTableAddPrimaryKeyConstraintTest - PhaseOne_AlterTableAddUniqueConstraintTest - PhaseOne_AvoidingInfiniteLoopAtStatementLevel - PhaseOne_AvoidingInfiniteRecursionAtBatchLevel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CREATE statement support: DATABASE, LOGIN, INDEX, ASYMMETRIC KEY,
SYMMETRIC KEY, CERTIFICATE, MESSAGE TYPE, SERVICE, QUEUE, ROUTE,
ENDPOINT, ASSEMBLY, APPLICATION ROLE, FULLTEXT CATALOG/INDEX,
REMOTE SERVICE BINDING, STATISTICS, TYPE, XML INDEX, PARTITION
FUNCTION/SCHEME, EVENT NOTIFICATION, CREDENTIAL, SYNONYM, RULE,
CONTRACT, AGGREGATE, EXTERNAL DATA SOURCE/FILE FORMAT/TABLE,
XML SCHEMA COLLECTION, ROLE, USER, SCHEMA, PROCEDURE, TRIGGER
Add ALTER DATABASE support: ADD FILE/FILEGROUP/LOG FILE,
MODIFY FILE/FILEGROUP/NAME, REMOVE FILE/FILEGROUP
Add ALTER statement support: APPLICATION ROLE, ASSEMBLY, ASYMMETRIC KEY,
CERTIFICATE, CREDENTIAL, ENDPOINT, FULLTEXT CATALOG/INDEX, LOGIN,
MASTER KEY, MESSAGE TYPE, PARTITION FUNCTION/SCHEME, QUEUE, REMOTE
SERVICE BINDING, ROLE, ROUTE, SERVICE MASTER KEY, SERVICE, SYMMETRIC KEY,
TABLE (constraint/trigger/drop), TRIGGER, USER, XML SCHEMA COLLECTION
Add BACKUP/RESTORE statement support
Add INSERT BULK and BULK INSERT support
Fix trigger parser panic on incomplete statements
Implement lenient parsing with skipToEndOfStatement() pattern