Skip to content

Add parser features and enable 8 more tests - #16

Merged
kyleconroy merged 3 commits into
mainfrom
claude/fix-skipped-parser-tests-cpyKt
Dec 17, 2025
Merged

kyleconroy merged 3 commits into
mainfrom
claude/fix-skipped-parser-tests-cpyKt

Conversation

@kyleconroy

Copy link
Copy Markdown
Collaborator
  • Add AlterCertificateStatement fields (Kind, ActiveForBeginDialog,
    PrivateKeyPath, DecryptionPassword, EncryptionPassword, AttestedBy)
  • Add AlterFulltextCatalogStatement fields (Action, Options)
  • Implement RenameEntityStatement for RENAME statement parsing
  • Add AlterDatabaseAddFileGroupStatement fields (ContainsFileStream,
    ContainsMemoryOptimizedData, UseCurrent)
  • Update PhaseOne test expected outputs for consistency
  • Enable AlterCertificateStatementTests, Baselines90_AlterCertificateStatementTests
  • Enable AlterFulltextCatalogStatementTests, Baselines90_AlterFulltextCatalogStatementTests
  • Enable RenameStatementTests, Baselines130_RenameStatementTests

- Add AlterCertificateStatement fields (Kind, ActiveForBeginDialog,
  PrivateKeyPath, DecryptionPassword, EncryptionPassword, AttestedBy)
- Add AlterFulltextCatalogStatement fields (Action, Options)
- Implement RenameEntityStatement for RENAME statement parsing
- Add AlterDatabaseAddFileGroupStatement fields (ContainsFileStream,
  ContainsMemoryOptimizedData, UseCurrent)
- Update PhaseOne test expected outputs for consistency
- Enable AlterCertificateStatementTests, Baselines90_AlterCertificateStatementTests
- Enable AlterFulltextCatalogStatementTests, Baselines90_AlterFulltextCatalogStatementTests
- Enable RenameStatementTests, Baselines130_RenameStatementTests
…tests

- Add AlterDatabaseScopedConfigurationClearStatement AST type
- Add DatabaseConfigurationClearOption type for CLEAR options
- Update parser to detect ALTER DATABASE SCOPED CONFIGURATION CLEAR
- Support optional PlanHandle binary literal in CLEAR statements
- Enable AlterDatabaseScopedConfigClearProcCacheTests150 (4 tests)

Total tests enabled in this branch: 10 (6 + 4)
New AST types and parsers:
- AlterResourceGovernorStatement (DISABLE, RECONFIGURE, RESET STATISTICS,
  WITH CLASSIFIER_FUNCTION)
- CreateCryptographicProviderStatement, AlterCryptographicProviderStatement,
  DropCryptographicProviderStatement
- UseFederationStatement (USE FEDERATION root WITH RESET, filtering)
- CreateFederationStatement, AlterFederationStatement (SPLIT AT, DROP AT LOW/HIGH)

Also fixes:
- AlterDatabaseModifyFileGroupStatement now includes MakeDefault,
  UpdatabilityOption, and NewFileGroupName fields
- Updated PhaseOne test ast.json files to match new output

Tests enabled (8 test pairs = 16 total):
- AlterResourceGovernorStatementTests (2)
- CryptographicProviderStatementTests (2)
- UseFederationTests110 (2)
- CreateAlterFederationStatementTestsAzure110 (2)
@kyleconroy
kyleconroy merged commit 3656485 into main Dec 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants