Skip to content

feat: add C implementation for blas/ext/base/ndarray/sany - #15274

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
himayurjogade:feature/blas-ext-base-ndarray-sany-c
Sep 28, 2026
Merged

feat: add C implementation for blas/ext/base/ndarray/sany#15274
kgryte merged 2 commits into
stdlib-js:developfrom
himayurjogade:feature/blas-ext-base-ndarray-sany-c

Conversation

@himayurjogade

@himayurjogade himayurjogade commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Part of #14819.

Description

What is the purpose of this pull request?

This pull request:

  • adds a C implementation for @stdlib/blas/ext/base/ndarray/sany.
  • adds a Node-API addon and tryRequire dispatcher with a fallback to the
    JavaScript implementation when the native addon is unavailable.
  • adds JavaScript and C benchmarks, along with a C example.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

AI assistance was used for reviewing changes and researching repository conventions.

I reviewed each file and verified the result locally: the native addon compiles without warnings, all 15 native test assertions pass with results consistent with the JavaScript implementation, the C example and C benchmarks run correctly, and ESLint reports no errors. Happy to make any adjustments.

@stdlib-js/reviewers

@himayurjogade
feat: add C implementation for blas/ext/base/ndarray/sany
90bd328 
Ref: stdlib-js#14819

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@himayurjogade
himayurjogade requested a review from a team September 16, 2026 18:12
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Sep 16, 2026
This was referenced Sep 17, 2026
Merged
Merged
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Sep 28, 2026
@stdlib-bot

stdlib-bot commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/sany $\\color{green}178/178$
$\\color{green}+100.00\\%$ 		$\\color{green}7/7$
$\\color{green}+100.00\\%$ 		$\\color{green}2/2$
$\\color{green}+100.00\\%$ 		$\\color{green}178/178$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 5 and removed Needs Review A pull request which needs code review. labels Sep 28, 2026
kgryte
kgryte reviewed Sep 28, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/ndarray/sany/README.md
@kgryte
Apply batched suggestions from code review
ce9cd0c 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Sep 28, 2026
View reviewed changes

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
kgryte merged commit e17a3f9 into stdlib-js:develop Sep 28, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. review: 4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@himayurjogade @stdlib-bot @kgryte