Skip to content

📝 Correct CAP-0075 interface errata - #1996

Merged
jayz22 merged 3 commits into
stellar:masterfrom
john-stellar:fix/cap-0075-interface-errata
Aug 20, 2026
Merged

jayz22 merged 3 commits into
stellar:masterfrom
john-stellar:fix/cap-0075-interface-errata

Conversation

@JFWooten4

Copy link
Copy Markdown
Contributor

Fixes #1980

cc @jayz22

Align field selectors with the shipped Symbol ABI and correct protocol availability.

Co-authored-by: Codex <noreply@openai.com>
Copilot AI balanced review requested due to automatic review settings August 6, 2026 11:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Corrects CAP-0075’s normative interface documentation to match the Protocol 25 implementation.

Changes:

  • Changes field selectors from numeric U32Val values to named Symbol values.
  • Corrects availability from Protocol 24 to Protocol 25.

@leighmcculloch
leighmcculloch requested a review from jayz22 August 17, 2026 05:42

@jayz22 jayz22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! I tagged on another commit with some additional clarifications for better alignment with the code.

@jayz22
jayz22 merged commit d186cf3 into stellar:master Aug 20, 2026
4 checks passed
@JFWooten4
JFWooten4 deleted the fix/cap-0075-interface-errata branch August 20, 2026 16:51
@JFWooten4

JFWooten4 commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Next time I think it'd be a lot better if we included the Oxford comma. It isn't entirely clear whether the state sizes are part of the box or their own constituent element. I'm not technically familiar (as I would expect many readers aren't), and so I can't derive that from intuition.

kalepail added a commit to stellar-experimental/stellar-raven that referenced this pull request Aug 28, 2026
…ings re-checked

Lane A: improvements:lint now enforces the 20-120 character upstreamTitle cap and
requires the field past `proposed` unless the record carries a GitHub issue/PR ref
(grandfather). The cap constants and the GitHub-ref regex live once in
scripts/improvements-lib.mjs; the filer reads the same constants. Nine new tests.

Lane B: live re-checks with dated evidence. sd-036 -> fixed-upstream
(stellar/stellar-protocol#1996 merged; live CAP-0075 source verified). sls-023,
sls-024, sls-029, sls-033 still reproduce against Scout API 1.9.1 and keep
reported-upstream with recurrences. sd-001 recorded against the settled Algolia
crawl (primary and replica disagree on one control). sls-077 and sls-078 are
filing-ready; owner-facing text rewritten to state the Scout contract defect.

Lane C (read-only): retirement review of the seven fixed-upstream findings; all
seven verified fixed live. No file was deleted and nothing was posted upstream;
those steps wait for owner authorization. Ledger:
.agents/rounds/2026-08-28-improvements-hygiene.md.

Independent review: Grok 4.6 high, two repair rounds, PASS.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kalepail added a commit to stellar-experimental/stellar-raven that referenced this pull request Aug 28, 2026
…ings re-checked (#87)

* improvements: hygiene sweep — lint enforces upstreamTitle, stale findings re-checked

Lane A: improvements:lint now enforces the 20-120 character upstreamTitle cap and
requires the field past `proposed` unless the record carries a GitHub issue/PR ref
(grandfather). The cap constants and the GitHub-ref regex live once in
scripts/improvements-lib.mjs; the filer reads the same constants. Nine new tests.

Lane B: live re-checks with dated evidence. sd-036 -> fixed-upstream
(stellar/stellar-protocol#1996 merged; live CAP-0075 source verified). sls-023,
sls-024, sls-029, sls-033 still reproduce against Scout API 1.9.1 and keep
reported-upstream with recurrences. sd-001 recorded against the settled Algolia
crawl (primary and replica disagree on one control). sls-077 and sls-078 are
filing-ready; owner-facing text rewritten to state the Scout contract defect.

Lane C (read-only): retirement review of the seven fixed-upstream findings; all
seven verified fixed live. No file was deleted and nothing was posted upstream;
those steps wait for owner authorization. Ledger:
.agents/rounds/2026-08-28-improvements-hygiene.md.

Independent review: Grok 4.6 high, two repair rounds, PASS.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* improvements: guard malformed evidence in the upstreamTitle lint

Copilot review on #87: upstreamTitleError and the lint's GitHub-ref checks
called .some() on fm.evidence unconditionally, so a malformed
`evidence: foo` would throw instead of reaching the lint's own list error.
Both now treat a non-array as empty. One test added.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: record the rebase in the hygiene round ledger

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CAP-0075 protocol-version and field-selector contradictions

3 participants