Skip to content

skipRemoteConfig Necessary? #45

New issue
New issue
Open
Open
skipRemoteConfig Necessary?#45

Description

@rdegges
rdegges
opened on Mar 22, 2016

stormpath-node-config/lib/strategy/EnrichClientFromRemoteConfigStrategy.js

Lines 81 to 83 in c11f1f5

if (config.skipRemoteConfig) {
return callback(null, config);
}

It looks like this was just added for testing convenience. Are we using this anywhere else? I'm working on the python version of this, and can't really seem to find a use for it.

Thinking about dropping support for it, but didn't want to break anything =)

Activity

  1. robertjd commented on Mar 22, 2016

    @robertjd
    robertjd
    on Mar 22, 2016
    Member

    I'm pretty sure that we removed anything that depended on it, that was our intention. I'd need to dig in to be certain, though.

  2. rorheden commented on Aug 11, 2016

    @rorheden
    rorheden
    on Aug 11, 2016
    Contributor

    Yeah, this was really just a convenience thing for testing. It should probably be refactored :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions