Remove warnings from useDeepCompareEffect

Is your feature request related to a problem? Please describe.

useDeepCompareEffect gives warnings when using it with primitive dependencies. This is frustrating for the common case where dependencies could either undefined or an object that you'd like to be deep-compared.

Describe the solution you'd like

Remove warnings from useDeepCompareEffect or provide a way to suppress warnings.

Any example?

import React from "react";
import { useDeepCompareEffect } from "react-use";

export const useObjectDidChange = <T extends any>(didChange: () => void, dep: T) => {
   useDeepCompareEffect(() => {
    didChange();
   }, [dep]);
}

function App = () => {
  const [obj, setObj] = useState<object | undefined>(undefined);
  useObjectDidChange(() => console.log("obj changed"), obj);
  
  return <div />;
}

This code will log a warning whenever obj is set to undefined.

I understand that the warning is there to help users. We should be using useEffect when the values of the dependency array are primitives. However, it's possible for the values of the array to change from primitive to non-primitive (as shown above). In that case, there should be no warning. It is correct to use useDeepCompareEffect if the value of the dependency is either a primitive or a non-primitive.

That warning is only valid if it is always primitive.

If the above case doesn't satisfy you, I'd at least add the option to hide warnings from react-use. Warnings are definitely useful and I appreciate that they're in react-use. However, they clutter the console and, in this case, I simply don't agree with the warning but would still like to continue using react-use.

@garrettmaring I agree, I think the warnings for primitives in useDeepCompareEffect (and shallow compare) should be removed.

But the other warning about no dependencies should probably stay.

Is this issue open? Can anyone assign this to me?

Can I work on this if still open?

fix: Remove warnings from useDeepCompareEffect (fixes streamich#755)

feat: Add production-grade warning suppression for useDeepCompareEffe…

feat: Add warning suppression for useDeepCompareEffect (fixes streami…

fix: Remove warnings from useDeepCompareEffect (fixes streamich#755)

fix: remove warnings from useDeepCompareEffect

fix: remove all-primitive-deps warning from useDeepCompareEffect (closes

fix: remove all-primitive-deps warning from useShallowCompareEffect (c…

Navigation Menu

Repository navigation

Remove warnings from `useDeepCompareEffect` #755

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Remove warnings from useDeepCompareEffect #755

Description

Activity

xobotyi commented on Nov 6, 2019

geraldarthurdavis commented on Nov 7, 2019

geraldarthurdavis commented on Nov 7, 2019

geraldarthurdavis commented on Feb 12, 2020

streamich commented on Feb 15, 2020

streamich commented on Feb 15, 2020

tusharkrbarman commented on Jan 30, 2023

shrutipandya3 commented on Oct 28, 2025

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Remove warnings from `useDeepCompareEffect` #755