Repository navigation
[charts/sn-platform, sn-platform-slim] Address security findings - #1284
Merged
Merged
Conversation
|
@tuteng:Thanks for your contribution. For this PR, do we need to update docs? |
|
@tuteng:Thanks for providing doc info! |
labuladong
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
sn-platformandsn-platform-slim.proxy.securityContext.readOnlyRootFilesystem: trueby default in both charts. The existingproxy.securityContexttemplate passes this policy toPulsarProxy.spec.pod.securityContext, including the generatedcheck-brokerinit container with the updated operator.0values.Validation
helm lintpasses for both charts with default and all chart CI values files.helm templateconfirms both Proxy CRs containspec.pod.securityContext.readOnlyRootFilesystem: trueby default, and optional numeric fields preserve0.pulsarnamespace with a read-only Proxy main container. Live validation of the new operator-generatedcheck-brokercontext is pending access to the upgraded cluster.Documentation
doc— updated both chart READMEs with the operator dependency and Proxy security context behavior.