Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both presentation adapters now consume the same admitted DocumentFacade snapshot and Core inspection receipt. The Editor renders the receipt's verdict, coverage, limitations, finding IDs and available intents; the headless adapter emits matching text from the same typed projection. No adapter parses a report or reduces a verdict.
Closes #26.
Stacked on #189 at
309888d641efd0b34d5d44bf2ae8b3b6179eb523, as approved. Merge #189 first; this PR's diff contains only #26.Changed files: the Interaction presentation header, Editor host/QML and its smoke mirror, facade tests, product smoke/fixture helper, and required change/evidence fragments.
Validation source:
52fa0d012a734592679a88583e78ab3710b6a79c.Commands, with the existing approved temporary build and Qt/MSVC runtime:
Scope/limits: fixtures are synthetic Core evidence bound to a real opened one-page PDF, not PDF inspection qualification. This proves adapters over admitted snapshots; migrating existing preflight job orchestration to the new facade lifecycle is outside this issue. Linux/macOS screenshots and assistive speech were not tested. The hosted CI/CodeQL workflows target dev/unstable/stable and are not scheduled for this stacked base; they must run after the parent merges and this PR is retargeted. Native Windows capture is used because the offscreen platform produced missing-font boxes.
Quality review: the full diff was reviewed for duplicated verdict/policy logic, redundant checks, explanatory comments and unnecessary wrappers. Shared projection code reads the accepted receipt and existing facade intent predicates; adapter-specific code only changes presentation shape.
Exact receipt SHA256 values from the final Windows capture (each matches its saved canonical receipt JSON):
Inspected smoke executable SHA256: B17064AB33B3C1133E14070C7488E1CCAD5C259A758B18AC4047FC4D22F00BA6.
Local artifact directory:
%TEMP%/loop-issue26-parity-final-52fa0d01; containsadapter-parity.json, the PDF fixture, four canonical receipt JSON files, four headless text files and four Editor PNG captures. Model log:%TEMP%/loop-issue26-model-final-52fa0d01.txt.