What do you think of having a separate module called motifs.py where we have an implementation of the k-top-motif search?
Do you think you could provide a checklist on the steps that you think are necessary to get this to work?
I would suggest the following:
- Leave core.mass as it is, because 8t does exactly what MASS was made for, i.e. finding the distance profile of a query.
- Rename stump.mass like you proposed
- In motifs.py have a function
find_occurences (or something different) that does the following:
- Gets a query Q, time series T and optionally the index of Q in T and an exclusion zone.
- Replaces nan/inf in a copy of T and computes mean and stddev (basically does all the usual preprocessing)
- Computes the distance profile of Q and T (the modified version) using core.mass, and if provided applies the exclusion zone.
- Returns all indices below a threshold
- Then around this function (and by doing some caching, as to not do the preprocessing of T every time) one cans build a k motif search implementation.
Originally posted by @mexxexx in #166 (comment)
What do you think of having a separate module called
motifs.pywhere we have an implementation of the k-top-motif search?I would suggest the following:
find_occurences(or something different) that does the following:Originally posted by @mexxexx in #166 (comment)