Skip to content

Limiting the scope of plugin files. - #80

Merged
fleischie merged 2 commits into
styled-components:developfrom
stevematney:typescript-fix
Oct 5, 2020
Merged

fleischie merged 2 commits into
styled-components:developfrom
stevematney:typescript-fix

Conversation

@stevematney

@stevematney stevematney commented Oct 5, 2020 •

Copy link
Copy Markdown
Contributor

Previously, we were loading all known javascript files for anything not specifically javascript. Now, we're only referencing the specific plugin files we intend to reference for syntax highlighting and indentation in styled-components. This should resolve any conflicts with other plugins.

after/indent/typescript.vim, after/indent/javascriptreact.vim,
and jsx.vim

* Not pulling in every indent/javascript.vim file.
* Resolves styled-components#75
* Resolves styled-components#76
@stevematney stevematney changed the title Limiting the scope of indent files. Limiting the scope of plugin files. Oct 5, 2020
@stevematney

Copy link
Copy Markdown
Contributor Author

Just to explain a bit on why this fix works: source allows us to read one specific file, which seems to be the intention of the previous runtime calls. The previous calls were doing much too broad of a search, and incidentally pulling in all the javascript syntax/indent/etc files from every plugin (including vim-styled-components) for all non-js filetypes (as described in the runtime help docs). This is why there were so many conflicts with other plugins.

@fleischie

Copy link
Copy Markdown
Collaborator

I unfortunately don't have the time/energy/...desire(?) to test this fully, so I suggest I merge this branch and let the potential issues flow in...

Also you are aware, that now with two merged PRs you are the most likely candidate to become the maintainer of this project? (Slightly joking, but not really. 😅 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants