Repository navigation
Quote the SU2 executable path in SU2_PY on Linux/macOS (SU2_RUN with spaces) - #2935
Merged
bigfooted merged 2 commits intoOct 10, 2026
Merged
Conversation
SU2_RUN containing a space broke SU2_PY on Linux/macOS because the executable path was only quoted on Windows. Quote it in build_command (shlex.quote on POSIX, double quotes on Windows) and pass plain "SU2_XXX config.cfg" strings from the callers.
joshkellyjak
approved these changes
Oct 9, 2026
joshkellyjak
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Minor: interface.quote was a module-level name, so out-of-tree scripts could possibly reference it. I think removing it is fine, but please mention it in the PR description so it ends up in the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix, see the diff.