Skip to content

GitHub integration branch functionality broken when using remotes with default auth.email.template.*.content_path values #2963

Closed

Description

@icopp

Describe the bug
When attempting to use a persistent branch with remotes values for auth.email.template.*.content_path in config.toml, the GitHub integration breaks on PRs with a Invalid config for (name): open (path): no such file or directory error.

To Reproduce

  • Create a monorepo with a Supabase config.toml in one package
  • In the config.toml, set values for auth.email.template.*.content_path. For example:
    [auth.email.template.confirmation]
    subject = "Confirm Your Signup"
    content_path = "./supabase/templates/confirmation.html"
    
  • Set up a persistent branch via CLI
  • In the config.toml, add a remotes entry. For example:
    [remotes.staging]
    project_id = "some-project-id-here"
    
  • Create a GitHub PR using the persistent branch
  • GitHub Supabase integration fails with an error around the auth.email.template.*.content_path setting

Expected behavior

  • GitHub Supabase integration should work as expected, either by using the given file (which exists) or ignoring it

Screenshots
If applicable, add screenshots to help explain your problem.

System information

  • Rerun the failing command with --create-ticket flag: n/a
  • Versions of services:
            SERVICE IMAGE      │      LOCAL       │  LINKED
    ─────────────────────────┼──────────────────┼────────────
      supabase/postgres      │ 15.1.1.78        │ 15.1.1.78
      supabase/gotrue        │ v2.164.0         │ v2.164.0
      postgrest/postgrest    │ v12.2.2          │ v12.2.2
      supabase/realtime      │ v2.33.58         │ -
      supabase/storage-api   │ v1.14.4          │ v1.14.4
      supabase/edge-runtime  │ v1.65.3          │ -
      supabase/studio        │ 20241202-71e5240 │ -
      supabase/postgres-meta │ v0.84.2          │ -
      supabase/logflare      │ 1.4.0            │ -
      supabase/supavisor     │ 1.1.56           │ -
    

Additional context
n/a

Activity

  1. changed the title [-]GitHub branchfunctionality broken when using `remotes` with default `auth.email.template.*.content_path` values[/-] [+]GitHub integration branch functionality broken when using `remotes` with default `auth.email.template.*.content_path` values[/+] on Dec 10, 2024
  2. sweatybridge commented on Dec 11, 2024

    @sweatybridge
    Contributor

    Thanks for reporting this issue. It's apparently working only if supabase directory is at top level of your repo. I will push a fix for monorepo setups where supabase directory is nested somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions