Repository navigation
refactor(cli): cover config push tests with effect lint (CLI-2486) - #6796
Conversation
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews were available. The reported inconsistency in the live test is confirmed as a nit; the test still captures and reports the failure. No additional verified findings emerged from the changed code. This was a static review.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/commands/config/push/push.live.test.ts:137 |
consistency |
claude | The target and cleanup generators call requireLiveSuccess directly, so a failed check becomes an Effect defect, while diffMaxRows converts the same check into a typed LiveConfigPushError. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
… 7ttp/cli-2486-config-family-coverage-push-tests
avallete
left a comment
There was a problem hiding this comment.
Tests only. push.e2e / push.integration / push.live are re-excluded from effect lint after the push/** ignore is lifted for the runtime files. Assertions moved to Cause.pretty / error fields and still check the same messages. No runtime behavior change.
TL;DR
brings the
supabase config pushtests under the effect lint, which completes theconfigfamilywhats introduced?
effect lint applied to the
config pushtests:config/**entryFileSystem, seed linked project state throughsetup, and set env throughwithEnvVarenv(VAR)secret read from the root.envCause.pretty, and field checks read the typed error directlycliEffectfixture with its proofs polled on aScheduleref: