Skip to content

refactor(cli): cover config push tests with effect lint (CLI-2486) - #6796

Merged
7ttp merged 2 commits into
7ttp/cli-2486-config-family-coverage-push-runtimefrom
7ttp/cli-2486-config-family-coverage-push-tests
Sep 24, 2026
Merged

7ttp merged 2 commits into
7ttp/cli-2486-config-family-coverage-push-runtimefrom
7ttp/cli-2486-config-family-coverage-push-tests

Conversation

@7ttp

@7ttp 7ttp commented Sep 24, 2026

Copy link
Copy Markdown
Member

TL;DR

brings the supabase config push tests under the effect lint, which completes the config family

whats introduced?

effect lint applied to the config push tests:

  • the per subcommand allow list entries collapse into one config/** entry
  • integration tests write fixtures through FileSystem, seed linked project state through setup, and set env through withEnvVar
  • both test setups provide the CLI config provider like production, with a new case for an env(VAR) secret read from the root .env
  • v1 mock failures are real transport errors
  • cause assertions use Cause.pretty, and field checks read the typed error directly
  • e2e tests run through the effect native harness, the live test through the cliEffect fixture with its proofs polled on a Schedule

ref:

@7ttp 7ttp self-assigned this Sep 24, 2026
@7ttp
7ttp added this pull request to stack #6794 September 24, 2026 10:45
@7ttp
7ttp requested a review from a team as a code owner September 24, 2026 10:45

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews were available. The reported inconsistency in the live test is confirmed as a nit; the test still captures and reports the failure. No additional verified findings emerged from the changed code. This was a static review.

Findings

Severity Location Category Sources Claim
⚪ NIT apps/cli/src/commands/config/push/push.live.test.ts:137 consistency claude The target and cleanup generators call requireLiveSuccess directly, so a failed check becomes an Effect defect, while diffMaxRows converts the same check into a typed LiveConfigPushError.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

Comment thread apps/cli/src/commands/config/push/push.live.test.ts

@avallete avallete left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests only. push.e2e / push.integration / push.live are re-excluded from effect lint after the push/** ignore is lifted for the runtime files. Assertions moved to Cause.pretty / error fields and still check the same messages. No runtime behavior change.

@7ttp
7ttp added this pull request to the merge queue Sep 24, 2026
Merged via the queue into develop with commit f26ffc1 Sep 24, 2026
29 checks passed
@7ttp
7ttp deleted the 7ttp/cli-2486-config-family-coverage-push-tests branch September 24, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants