refactor(cli): cover db advisors, db lint and db query with effect lint (CLI-2409)

[7ttp]

TL;DR

brings supabase db advisors, db lint and db query under the effect lint

whats introduced?

effect lint applied to db advisors, db lint and db query:

• allow list entries for db/advisors, db/lint and db/query
• typed errors are yielded directly instead of through Effect.fail
• the linked db query response decodes through Schema.decodeOption, and its timestamps go through DateTime with the same output
• the advisors body parse keeps its native parse error message, now pinned by a test
• cause assertions use Cause.pretty, and the query tests use scoped temp dirs through FileSystem
• live tests run through the cliEffect fixture

ref:

• related: CLI-2409

[github-actions]

🤖 AI Review

The reviewed changes show no confirmed runtime regression. The merged findings identify one live-test cancellation and cleanup issue and one overly specific JSON assertion.

Findings

Severity	Location	Category	Sources	Claim
🟡 MINOR	apps/cli/src/commands/db/advisors/advisors.live.test.ts:10	test-reliability	claude+codex	The advisors and lint live tests omit the Vitest abort signal when running CLI effects. A timed-out test therefore cannot interrupt its running CLI effect, and the database cleanup is not protected against interruption if cancellation is added.
⚪ NIT	apps/cli/src/commands/db/query/query.integration.test.ts:465	test-quality	codex	The new stream JSON assertion requires exact indentation spaces, so an equivalent valid one-line JSON serialization would fail the test.

Stats

Claude findings: 1 · Codex findings: 2 · Confirmed: 2 · Refuted: 0 · Uncertain: 0

---

Models: claude-opus-5-5 + gpt-6-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

[avallete]

Effect-lint coverage for db advisors, db lint, and db query looks mechanical.

Failures are the same tagged errors, now yielded directly. Stream-json timestamps use DateTime.formatIso on a UTC clock, which still formats as toISOString (…sssZ). Response JSON still goes through JSON.parse. Existing tests are still there, and the malformed advisors body case was added.