Skip to content

refactor(cli): cover db start with effect lint (CLI-2409) - #6814

Merged
7ttp merged 1 commit into
7ttp/cli-2409-db-family-coverage-push-dumpfrom
7ttp/cli-2409-db-family-coverage-start
Sep 25, 2026
Merged

7ttp merged 1 commit into
7ttp/cli-2409-db-family-coverage-push-dumpfrom
7ttp/cli-2409-db-family-coverage-start

Conversation

@7ttp

@7ttp 7ttp commented Sep 24, 2026

Copy link
Copy Markdown
Member

TL;DR

brings supabase db start under the effect lint

whats introduced?

effect lint applied to db start:

  • one allow list entry for db/start
  • the backup error is yielded directly
  • integration tests write config.toml and .env through the layer setup returns, so test bodies stay unchanged, and set env through withEnvVar only where a test depends on it
  • cause assertions use Cause.pretty, and the roles e2e decodes through Schema
  • the e2e test runs through the effect native harness with its stop cleanup in Effect.ensuring

ref:

@7ttp 7ttp self-assigned this Sep 24, 2026
@7ttp
7ttp added this pull request to stack #6813 September 24, 2026 20:46
@7ttp
7ttp requested a review from a team as a code owner September 24, 2026 20:46

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews reported no findings. The changed handler, tests, and supporting helpers reveal no concrete regression on code inspection. Tests were not run in this read-only adjudication.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@avallete avallete left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect-lint coverage for db start looks mechanical.

The handler only switches yield* Effect.fail(new …Error) to yield* new …Error on the same tagged error. Tests are unchanged aside from Effect-style setup.

@avallete
avallete added this pull request to the merge queue Sep 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Sep 25, 2026
@7ttp
7ttp added this pull request to the merge queue Sep 25, 2026
Merged via the queue into develop with commit b58d5ab Sep 25, 2026
35 checks passed
@7ttp
7ttp deleted the 7ttp/cli-2409-db-family-coverage-start branch September 25, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants