Skip to content

refactor(cli): cover db reset with effect lint (CLI-2409) - #6815

Merged
7ttp merged 1 commit into
7ttp/cli-2409-db-family-coverage-startfrom
7ttp/cli-2409-db-family-coverage-reset
Sep 25, 2026
Merged

7ttp merged 1 commit into
7ttp/cli-2409-db-family-coverage-startfrom
7ttp/cli-2409-db-family-coverage-reset

Conversation

@7ttp

@7ttp 7ttp commented Sep 24, 2026

Copy link
Copy Markdown
Member

TL;DR

brings supabase db reset under the effect lint

whats introduced?

effect lint applied to db reset:

  • one allow list entry for db/reset
  • typed errors are yielded directly
  • integration tests write project files through the layer setup returns, and the permission tests restore file modes with acquireUseRelease
  • cause assertions use Cause.pretty, and suggestion checks read the typed error directly
  • the vector bucket request body encodes through Schema
  • the e2e test runs through the effect native harness, the live test through the cliEffect fixture

ref:

@7ttp 7ttp self-assigned this Sep 24, 2026
@7ttp
7ttp added this pull request to stack #6813 September 24, 2026 20:49
@7ttp
7ttp requested a review from a team as a code owner September 24, 2026 20:49

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews reported no findings. I inspected the changed code and surrounding test setup, and found no concrete regression. Tests were not run because this checkout has no installed dependencies.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@avallete avallete left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect-lint coverage for db reset looks mechanical.

Flag and cancellation failures are the same tagged errors, now yielded directly. Tests are unchanged aside from Effect-style setup.

@avallete
avallete added this pull request to the merge queue Sep 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Sep 25, 2026
@7ttp
7ttp added this pull request to the merge queue Sep 25, 2026
Merged via the queue into develop with commit 4ebe5de Sep 25, 2026
35 checks passed
@7ttp
7ttp deleted the 7ttp/cli-2409-db-family-coverage-reset branch September 25, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants