Repository navigation
refactor(cli): cover db schema declarative generate with effect lint (CLI-2409) - #6819
Conversation
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews reported no findings. A separate check of the changed code found no actionable regression. Tests were not run because dependencies are absent from the read-only checkout.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
…-db-family-coverage-schema-generate
avallete
left a comment
There was a problem hiding this comment.
Effect-lint coverage for declarative generate looks mechanical.
layeredParseEnv is the previous (name) => process.env[name] ?? projectEnv[name] lookup. Other failures are the same tagged errors, now yielded directly. Tests are still there; the corrupt-manifest expect is now the full error string, including the native JSON parse message.
…-db-family-coverage-schema-generate
TL;DR
brings
supabase db schema declarative generateand the shared declarative helpers under the effect lintwhats introduced?
effect lint applied to
db schema declarative generate:db/schema/declarativehelpers andgeneratePG*fallbacks through the same layered env as--db-urlFileSystemandPath, set env throughwithEnvVar, and pin the native manifest parse errorref: