Skip to content

refactor(cli): cover db schema declarative generate with effect lint (CLI-2409) - #6819

Merged
7ttp merged 3 commits into
7ttp/cli-2409-db-family-coverage-pullfrom
7ttp/cli-2409-db-family-coverage-schema-generate
Sep 25, 2026
Merged

7ttp merged 3 commits into
7ttp/cli-2409-db-family-coverage-pullfrom
7ttp/cli-2409-db-family-coverage-schema-generate

Conversation

@7ttp

@7ttp 7ttp commented Sep 24, 2026

Copy link
Copy Markdown
Member

TL;DR

brings supabase db schema declarative generate and the shared declarative helpers under the effect lint

whats introduced?

effect lint applied to db schema declarative generate:

  • allow list entries for the db/schema/declarative helpers and generate
  • typed errors are yielded directly
  • the custom database url prompt resolves PG* fallbacks through the same layered env as --db-url
  • tests use FileSystem and Path, set env through withEnvVar, and pin the native manifest parse error

ref:

@7ttp 7ttp self-assigned this Sep 24, 2026
@7ttp
7ttp added this pull request to stack #6813 September 24, 2026 20:57
@7ttp
7ttp requested a review from a team as a code owner September 24, 2026 20:57

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews reported no findings. A separate check of the changed code found no actionable regression. Tests were not run because dependencies are absent from the read-only checkout.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@avallete avallete left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect-lint coverage for declarative generate looks mechanical.

layeredParseEnv is the previous (name) => process.env[name] ?? projectEnv[name] lookup. Other failures are the same tagged errors, now yielded directly. Tests are still there; the corrupt-manifest expect is now the full error string, including the native JSON parse message.

@avallete
avallete added this pull request to the merge queue Sep 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Sep 25, 2026
@7ttp
7ttp added this pull request to the merge queue Sep 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Sep 25, 2026
@7ttp
7ttp added this pull request to the merge queue Sep 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Sep 25, 2026
@7ttp
7ttp added this pull request to the merge queue Sep 25, 2026
Merged via the queue into develop with commit 48e146e Sep 25, 2026
27 of 41 checks passed
@7ttp
7ttp deleted the 7ttp/cli-2409-db-family-coverage-schema-generate branch September 25, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants