Repository navigation
refactor(cli): cover db schema declarative sync with effect lint (CLI-2409) - #6820
Conversation
There was a problem hiding this comment.
🤖 AI Review
One minor test coverage gap is confirmed. The lint coverage finding is refuted: the new negated glob includes the db tree in Effect lint. No additional defect was verified. Tests were not run because dependencies are absent.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/commands/db/schema/declarative/sync/sync.integration.test.ts:1532 |
test-coverage |
claude | The new invalid transaction mode test checks only the error message. It does not verify the outward error tag or that no migration file was written. |
Refuted findings (kept for transparency, not posted as review comments)
.oxlintrc.effect.json:15(lint-coverage): The new glob excludes the entire db command tree from Effect lint, including the changed sync code.
Refuted: The!pattern reverses the initial ignore pattern and includes the db tree in lint coverage. The trusted baseline config uses the same negated pattern convention for other included command directories.
Stats
Claude findings: 1 · Codex findings: 1 · Confirmed: 1 · Refuted: 1 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
…7ttp/cli-2409-db-family-coverage-schema-sync
avallete
left a comment
There was a problem hiding this comment.
Effect-lint coverage for declarative sync looks mechanical.
Prompt and compatibility failures are the same tagged errors, now yielded directly. The oxlint include widens to commands/db/** now that the stack covers that tree. Tests are still there; the unknown pg-delta transaction mode case was added.
…7ttp/cli-2409-db-family-coverage-schema-sync
TL;DR
brings
supabase db schema declarative syncunder the effect lint, which completes thedbfamilywhats introduced?
effect lint applied to
db schema declarative sync:db/**entryDateTimewith the same outputFileSystemandPath, set env throughwithEnvVar, and pin the transaction mode messageacquireUseReleaseref: