Repository navigation
chore(cli): keep service Dockerfile image lines apart to avoid catalog PR conflicts - #6992
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews completed. The Dockerfile copies remain byte-identical, and their consumers tolerate blank lines. Claude's spacing-enforcement nit is confirmed; its suggestion that separators must be blank is unsupported because existing comment lines also prevent adjacency. No functional defects or additional findings were found.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/shared/services/Dockerfile:6 |
maintainability |
claude | The separator-line convention is documented but not enforced. Removing separators from both Dockerfile copies could restore adjacent image lines without failing the generator or existing tests. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
avallete
approved these changes
Oct 5, 2026
jgoux
force-pushed
the
chore/separate-dockerfile-image-lines
branch
from
October 5, 2026 10:31
ef72ad6 to
3ccc599
Compare
jgoux
enabled auto-merge
October 5, 2026 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every generated
FROMline in the service Dockerfiles sat next to another, so two catalog PRs for neighbouring aliases (pg and pg15, realtime and storage, …) always conflicted once the first one merged. A blank line between image lines lets git merge them independently, and the header says why.