Skip to content

refactor(cli): cover all of shared with effect lint (CLI-2458) - #7002

Merged
7ttp merged 1 commit into
developfrom
7ttp/cli-2458-shared
Oct 5, 2026
Merged

7ttp merged 1 commit into
developfrom
7ttp/cli-2458-shared

Conversation

@7ttp

@7ttp 7ttp commented Oct 5, 2026

Copy link
Copy Markdown
Member

TL;DR

collapses the effect lint allow list to one shared/** entry now that every shared area is covered, keeping its three existing exclusions..

ref

@7ttp 7ttp self-assigned this Oct 5, 2026
@7ttp
7ttp requested a review from a team as a code owner October 5, 2026 21:36

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews reported no findings. Verified that the consolidated shared-code glob covers the same existing files as the 14 replaced entries, preserves all three exclusions and their ordering, and leaves the remaining configuration unchanged. No issues found.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@7ttp
7ttp enabled auto-merge October 5, 2026 21:45
@7ttp
7ttp added this pull request to the merge queue Oct 5, 2026
Merged via the queue into develop with commit 1651b31 Oct 5, 2026
38 checks passed
@7ttp
7ttp deleted the 7ttp/cli-2458-shared branch October 5, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants