[WIP] Add PHP client by ackintosh · Pull Request #14 · swagger-api/swagger-codegen-generators

ackintosh · 2018-02-18T07:00:41Z

With reference to java, work in progress now. 👀

TODO

Fix build error
Make PhpClientCodegen/AbstractPhpCodegen DRY
etc...

copied from swagger-codegen:master

jmini · 2018-02-23T18:24:12Z

First idea: you should merge master to your feature branch or rebase all your commit on top of master.

This is what I did locally to review your code.

jmini · 2018-02-23T18:25:55Z

+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public abstract class AbstractPhpCodegen extends DefaultCodegenConfig {


DefaultCodegenConfig is not imported. add following line:

import io.swagger.codegen.languages.DefaultCodegenConfig;

jmini · 2018-02-23T18:28:23Z

+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class PhpClientCodegen extends DefaultCodegenConfig {


Same here: DefaultCodegenConfig is not imported.

jmini · 2018-02-23T18:30:13Z

@@ -0,0 +1,731 @@
+package io.swagger.codegen.languages;


Package should be: io.swagger.codegen.languages.php

jmini · 2018-02-23T18:30:21Z

@@ -0,0 +1,667 @@
+package io.swagger.codegen.languages;


Package should be: io.swagger.codegen.languages.php

jmini · 2018-02-23T18:35:50Z

+
+        if (example == null) {
+            example = "NULL";
+        } else if (Boolean.TRUE.equals(p.isListContainer)) {


This produces a compile error by p.isListContainer.

Where did you get this file? AbstractPhpCodegen on the 3.0.0 branch in the swagger-codegen has no copile error. You should have took this as base.

jmini · 2018-02-23T18:48:12Z

+
+        if (example == null) {
+            example = "NULL";
+        } else if (Boolean.TRUE.equals(p.isListContainer)) {


This produces a compile error by p.isListContainer.

Where did you get this file? PhpClientCodegen on the 3.0.0 branch in the swagger-codegen has no copile error. You should have took this as base.

jmini · 2018-02-23T18:50:05Z

I hope you will manage to remove the compile errors. Do not hesitate to ask if you need something.

jmini · 2018-02-24T17:57:07Z

In order to help you, I have started a wiki page:
Swagger Codegen migration (swagger codegen generators repository)

HugoMario · 2018-03-13T11:59:57Z

@ackintosh do you mind if we merge your fork with a different branch, in order to help with TO-DO tasks? or can you please grant access to HugoMario user in your forked repo?

ackintosh · 2018-03-19T07:34:43Z

Sorry for late reply 💦
No, I don't. Please start your work in a different branch. ✨

jmini · 2018-03-19T08:41:00Z

I have automated a lot of the work that is requested to migrate the generators, this is no problem for me to migrate the PHP generator.

But I will not be able to evaluate the generated code and to confirm that it works as expected.

How do you want to proceed? Should I start something and you will test it?
@HugoMario any other idea?

HugoMario · 2018-03-20T21:32:58Z

thanks @ackintosh
@jmini sure, let me merge this into a new branch php_client_generator, so you can add your work there and i can later verify the generated code.

jmini · 2018-03-21T06:05:03Z

I have fetched the php_client_generator branch, but there is nothing more than on the master branch. I think you should merge ackintosh/php-client on your new branch.

What is the idea?
Should I create a pull request for the new php_client_generator branch, should I push directly on the php_client_generator branch (but I think that I need a permission for that).

I can also fetch ackintosh/php-client locally, push the changes I had described in this merge request and then open a new one.

@HugoMario: I would appreciate if you could review and merge my existing pull requests for the swagger-codegen-generators and swagger-codegen repositories.

There is a lot important stuff going on in order to improve Swagger v3.

HugoMario · 2018-03-21T17:06:31Z

@jmini i already merge this PR against php_client_generator branch. So the idea is that any change you want to make, you can do it pointing to this branch.

ackintosh added 5 commits February 18, 2018 15:57

Add templates and codegen for PHP client

60404e9

copied from swagger-codegen:master

*Codegen extends DefaultCodegenConfig

787ae48

Fix getTypeDeclaration()

ccf3b4c

getSwaggerType -> getSchemaType

5455dc5

Fix toDefaultValue()

fd1596c

webron requested a review from HugoMario February 19, 2018 18:29

jmini reviewed Feb 23, 2018

View reviewed changes

HugoMario changed the base branch from master to php_client_generator March 20, 2018 21:32

HugoMario merged commit 25843ab into swagger-api:php_client_generator Mar 21, 2018

Conversation

ackintosh commented Feb 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

jmini commented Feb 23, 2018

Uh oh!

jmini Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

jmini Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

jmini Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

jmini Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

jmini Feb 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmini Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

jmini commented Feb 23, 2018

Uh oh!

jmini commented Feb 24, 2018

Uh oh!

HugoMario commented Mar 13, 2018

Uh oh!

ackintosh commented Mar 19, 2018

Uh oh!

jmini commented Mar 19, 2018

Uh oh!

HugoMario commented Mar 20, 2018

Uh oh!

jmini commented Mar 21, 2018

Uh oh!

HugoMario commented Mar 21, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ackintosh commented Feb 18, 2018 •

edited

Loading

jmini Feb 23, 2018 •

edited

Loading