Repository navigation
feat(postgres): adding upgrade scripts to the postgres - #12
Merged
Merged
Conversation
duanhongyi
force-pushed
the
master
branch
3 times, most recently
from
December 11, 2018 02:27
248a91f to
fa02c09
Compare
Cryptophobia
requested review from
Cryptophobia and
till
and removed request for
Cryptophobia
January 15, 2019 01:09
Member
|
@till Do you want to give this PR a glance as well? |
Cryptophobia
approved these changes
Jan 15, 2019
Member
|
Looks good to me and I am ready to merge. Anybody else want to give it a glance? @duanhongyi have you tested the upgrade process with different versions? |
|
@Cryptophobia Yeah, I can have a look after lunch, thanks for the ping! |
Member
|
Thanks @till ! Did you find anything that may be a problem in the future that may block this merge? |
till
reviewed
Jan 16, 2019
till
left a comment
There was a problem hiding this comment.
Minor question, otherwise, this looks good.
Member
|
Merged. Thank you for the contribution @duanhongyi ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is an implementation of this design(#11).