Skip to content

feat(postgres): adding upgrade scripts to the postgres - #12

Merged
Cryptophobia merged 1 commit into
teamhephy:masterfrom
duanhongyi:master
Jan 23, 2019
Merged

Cryptophobia merged 1 commit into
teamhephy:masterfrom
duanhongyi:master

Conversation

@duanhongyi

@duanhongyi duanhongyi commented Dec 4, 2018 •

Copy link
Copy Markdown
Member

It is an implementation of this design(#11).

@duanhongyi
duanhongyi force-pushed the master branch 3 times, most recently from 248a91f to fa02c09 Compare December 11, 2018 02:27
@Cryptophobia
Cryptophobia requested review from Cryptophobia and till and removed request for Cryptophobia January 15, 2019 01:09
@Cryptophobia

Copy link
Copy Markdown
Member

@till Do you want to give this PR a glance as well?

@Cryptophobia Cryptophobia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread rootfs/bin/do_upgrade Resolved
Comment thread rootfs/docker-entrypoint.sh Resolved
@Cryptophobia

Cryptophobia commented Jan 15, 2019 •

Copy link
Copy Markdown
Member

Looks good to me and I am ready to merge. Anybody else want to give it a glance?

@duanhongyi have you tested the upgrade process with different versions?

@till

till commented Jan 15, 2019

Copy link
Copy Markdown

@Cryptophobia Yeah, I can have a look after lunch, thanks for the ping!

@Cryptophobia

Copy link
Copy Markdown
Member

Thanks @till ! Did you find anything that may be a problem in the future that may block this merge?

@till till left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question, otherwise, this looks good.

Comment thread rootfs/bin/do_upgrade Resolved

@Cryptophobia Cryptophobia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Cryptophobia
Cryptophobia merged commit cff717b into teamhephy:master Jan 23, 2019
@Cryptophobia

Copy link
Copy Markdown
Member

Merged. Thank you for the contribution @duanhongyi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants