Repository navigation
Conversation
…ged out A delivered user message stays in the acknowledged list until the thread catches up to it. Servers that do not report the commit sequence leave only the message search as proof, and a bounded projection pages old messages out, so in a long thread the local copy came back appended at the bottom of the feed. threadHasCaughtUpTo now also treats a sequenceless write older than the loaded window, with earlier history unloaded, as caught up. A reported sequence the thread has not reached still outranks that guess. Both mobile readers (the feed selection and the acknowledged cleanup) pass the window bounds through. Co-Authored-By: Claude <noreply@anthropic.com>
tebiggs
force-pushed
the
fix/mobile-ack-window-fallback
branch
from
October 31, 2026 01:03
5f64b5e to
763b26d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the phone, the first message of a long thread (sent from mobile) kept reappearing as the last bubble in the feed. The truenas-dev server holds the thread in correct order — that message is item 0 of 549 — so the stray bubble is the phone's local "acknowledged" copy, kept until the thread catches up to it. Servers that do not report the commit sequence leave only a lookup in the loaded projection as proof, and the bounded snapshot pages old messages out, so the copy resurfaced appended at the bottom. Its 1:28 PM timestamp (the server's copy says 1:31 PM) confirmed it was the local copy.
threadHasCaughtUpTonow also treats a sequenceless write that is older than the loaded window, with earlier history unloaded, as caught up. A reported sequence the thread has not reached still outranks that guess, so a message merely awaiting its echo stays visible. Both mobile readers pass the window bounds through: the feed selection inpending-thread-feedand the acknowledged cleanup inacknowledged-thread-messages. This builds on the sequence-based fix already on main; it covers the mixed-version case of a current app against an older server (truenas-dev is still on 0.1.3-nightly).Verified:
vp run check:changedpasses (format, lint, knip, typecheck, tests beside the changes), plus the client-runtime thread sync/detail tests (59 passed). No before/after capture: reproducing needs an old server plus a long thread on a real phone; the regression test inpending-thread-feed.test.tscovers the ordering decision directly.Work by muse-wonder-full-1.0 in Muse Code (T3 Code harness).