Repository navigation
[SDK Sentinel] Fix flaky schedule interceptor visibility check - #3184
Open
sdk-sentinel-bot wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR contains untrusted AI-generated code. Do not approve or run CI until a maintainer has reviewed the diff. SDK Sentinel verified that GitHub Actions remained approval-gated with zero executable jobs when this PR was opened.
Summary
Stabilize
ScheduleTest.testInterceptorsafter a [same-SHA cloud attempt passed](https://github.com/temporalio/sdk-java/actions/runs/41173921213/job/124457428717) and its [rerun returned zero schedules](https://github.com/temporalio/sdk-java/actions/runs/41173921213/job/124464560263). Breaking changes: none. Server PR: none.Root cause
Schedule creation can complete before the eventually consistent Cloud list index exposes the schedule. The test assumed a fixed two-second delay was sufficient.
Fix
Poll visibility for up to 30 seconds through a client without tracing interceptors, then make the single intercepted list call whose behavior the test verifies.
Validation
The focused test passed four times against the loopback Temporal service; natural pre-change reproduction did not occur. The trusted unchanged baseline and validator-equivalent formatting/compilation checks passed. Exact candidate validation was blocked by read-only submodule Git metadata. The Cloud Java 23 job and canonical validator remain required.
Validation status:
validation-incompletehighhighmediumstandard— 1 changed file; 1.5 KiBnot-reproduced— One pre-change focused run passed against the loopback Temporal service; the slower Cloud visibility path was unavailable locally.pass-after-only— The existing test was converted into the regression check and passed four post-change loopback runs; no deterministic pre-change local failure occurred.Gradle formatting and test-source compilation) — passedGradle formatting and test-source compilation) — did not pass (failure)Investigator-run checks
USE_EXTERNAL_SERVICE=true TEMPORAL_SERVICE_ADDRESS=127.0.0.1:7233 ./gradlew --offline --no-daemon :temporal-sdk:cleanTest :temporal-sdk:test --tests 'io.temporal.client.schedules.ScheduleTest.testInterceptors' -x :temporal-serviceclient:initSubmodules -x :temporal-serviceclient:updateSubmodules— passed; 4 attempt(s). Four post-change runs passed against the preloaded loopback Temporal service..ci-flake-runtime/input/validate.sh (trusted unchanged baseline)— passed; 1 attempt(s). The trusted workflow recorded BUILD SUCCESSFUL for the unchanged checkout.GRADLE_USER_HOME=$PWD/.ci-flake-runtime/tmp/gradle-agent .ci-flake-runtime/input/validate.sh— failed; 1 attempt(s). Formatting passed, then validation was blocked when Gradle attempted to update read-only submodule Git metadata../gradlew --offline --no-daemon spotlessCheck testClasses -x test -x :temporal-serviceclient:initSubmodules -x :temporal-serviceclient:updateSubmodules— passed; 1 attempt(s). The validator-equivalent formatting and compilation checks passed when only the inaccessible submodule metadata tasks were excluded.Required target CI
Residual risks
Automation provenance
de77db89c65e164b14633744479cd25dc42f0d07If this finding should not be fixed, apply the
sdk-sentinel:false-positivelabel and close the PR. Sentinel will suppress the finding until its affected source changes.SDK Sentinel recurrence history
2026-10-31 05:57 UTC2026-11-03 21:38 UTC