[Feature Request] Support ExceptionGroup traceback #393

Activity

1. jashandeep-sohi

   added

   enhancementNew feature or requestNew feature or request

   on Oct 6, 2023
2. cretz commented on Oct 6, 2023

   

   cretz

   on Oct 6, 2023

   Last edited by cretz

   Contributor

   More actions

   I'm wondering if it's possible to use traceback.format_exception to get a output similar to what the Python spits out. That seems to include the sub-exceptions as-well. What's the advantage of using one over the other?

   I believe I used format_tb over format_exception because I want just the traceback in our failure stack_trace field, not other exception information or multiple tracebacks.

   We don't really have a concept of multiple exceptions in our failure message. I will discuss with the team on how best to support multiple exception stack traces, though it won't help immediately. You'll want to catch/log. But maybe we can just for ExceptionGroup we can use format_exception.

   There's another problem with ExceptionGroup - we only fail the workflow on FailureError based exceptions, all others fail the task (which means suspend the workflow until a code fix is deployed to fix the unexpected error). ActivityError is a FailureError so if raised out of the workflow that will fail the workflow, but ExceptionGroup is not that type so it will be treated differently. So really, you'll probably need to catch the exception and re-raise as ApplicationError anyways, and it's at this time you can log if needed.

   (feel free to also come discuss details on our #python-sdk channel on our public Slack at https://t.mp/slack if that's easier)
3. jashandeep-sohi commented on Oct 6, 2023

   

   jashandeep-sohi

   on Oct 6, 2023

   Author

   More actions

   I believe I used format_tb over format_exception because I want just the traceback in our failure stack_trace field, not other exception information or multiple tracebacks.

   Oh, I see. The Failure proto has a cause Failure, so you're keeping track of every level individually, that format_exception would also render if used.

   My interaction with this field is mostly via the UI where it renders the traceback. As a Python developer I was expecting it to look similar to when an exception is printed by the Python interpreter to the console. And I think for the most part it does.

   We don't really have a concept of multiple exceptions in our failure message. I will discuss with the team on how best to support multiple exception stack traces, though it won't help immediately. You'll want to catch/log. But maybe we can just for ExceptionGroup we can use format_exception.

   Thanks!

   There's another problem with ExceptionGroup - we only fail the workflow on FailureError based exceptions, all others fail the task (which means suspend the workflow until a code fix is deployed to fix the unexpected error). ActivityError is a FailureError so if raised out of the workflow that will fail the workflow, but ExceptionGroup is not that type so it will be treated differently. So really, you'll probably need to catch the exception and re-raise as ApplicationError anyways, and it's at this time you can log if needed.

   Yup, that's what I was expecting. I don't want the ExceptionGroup to fail the workflow, I'd just like to be able to see the sub-exceptions' traceback in the UI and try to possibly fix the workflow.
4. cretz commented on Oct 6, 2023

   

   cretz

   on Oct 6, 2023

   Last edited by cretz

   Contributor

   More actions

   Yup, that's what I was expecting. I don't want the ExceptionGroup to fail the workflow, I'd just like to be able to see the sub-exceptions' traceback in the UI and try to possibly fix the workflow.

   We should be logging it on the worker as a task failure (with log line starting with "Failed handling activation on workflow with run ID"). I cannot currently think of a good way to display multiple aggregate exceptions in our model today that would work well. Also the serialized failure has some size limits that could be more easily reached on aggregate exceptions with stack traces. I think for this case, the UI is not going to be better than logs for retrieving this level of detail.
5. cretz commented on Oct 20, 2023

   

   cretz

   on Oct 20, 2023

   Contributor

   More actions

   Closing as there is nothing actionable to do here. Exception group is not serializable to a Temporal failure which is a single message w/ a single stack trace and a single cause.

   😕React with 😕1Reacted by James Thewlis
6. cretz

   closed this as not plannedon Oct 20, 2023