Repository navigation
💥 fix(client): use server schedule catchup window default - #1922
Merged
chris-olszewski merged 5 commits intoOct 5, 2026
Merged
Conversation
chris-olszewski
commented
Oct 5, 2026
Comment on lines
-1063
to
-1064
| catchup_window = google.protobuf.duration_pb2.Duration() | ||
| catchup_window.FromTimedelta(self.policy.catchup_window) |
Member
Author
There was a problem hiding this comment.
Not sure what this was supposed to do
chris-olszewski
marked this pull request as ready for review
October 5, 2026 16:16
tconley1428
reviewed
Oct 5, 2026
tconley1428
approved these changes
Oct 5, 2026
chris-olszewski
deleted the
fix/server-configured-schedule-catchup-default
branch
October 5, 2026 20:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
CatchUpWindownullable.Why?
This lets us respect a dynamic configuration set on server. Matches Java behavior.
Checklist
Closes N/A
How was this tested:
Super basic unit test just to verify null and an explicit zero have the correct wire representations.
Any docs updates needed?
Update doc comments.