Skip to content

💥 fix(client): use server schedule catchup window default - #1922

Merged
chris-olszewski merged 5 commits into
mainfrom
fix/server-configured-schedule-catchup-default
Oct 5, 2026
Merged

chris-olszewski merged 5 commits into
mainfrom
fix/server-configured-schedule-catchup-default

Conversation

@chris-olszewski

Copy link
Copy Markdown
Member

What was changed

  • No longer set a client side default for catch up window.
  • Make CatchUpWindow nullable.

Why?

This lets us respect a dynamic configuration set on server. Matches Java behavior.

Checklist

  1. Closes N/A

  2. How was this tested:
    Super basic unit test just to verify null and an explicit zero have the correct wire representations.

  3. Any docs updates needed?
    Update doc comments.

Comment on lines -1063 to -1064
catchup_window = google.protobuf.duration_pb2.Duration()
catchup_window.FromTimedelta(self.policy.catchup_window)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this was supposed to do

@chris-olszewski
chris-olszewski marked this pull request as ready for review October 5, 2026 16:16
@chris-olszewski
chris-olszewski requested a review from a team as a code owner October 5, 2026 16:16
Comment thread temporalio/client/_schedule.py Resolved
@chris-olszewski
chris-olszewski merged commit 16a4ef2 into main Oct 5, 2026
47 of 49 checks passed
@chris-olszewski
chris-olszewski deleted the fix/server-configured-schedule-catchup-default branch October 5, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants