Skip to content

Rename sdk-features to features" - #248

Merged
bergundy merged 1 commit into
temporalio:mainfrom
bergundy:features-repo-rename
Jan 12, 2023
Merged

bergundy merged 1 commit into
temporalio:mainfrom
bergundy:features-repo-rename

Conversation

@bergundy

Copy link
Copy Markdown
Member

@bergundy
bergundy requested a review from cretz January 10, 2023 23:30
@CLAassistant

CLAassistant commented Jan 10, 2023 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@bergundy bergundy closed this Jan 11, 2023
@bergundy bergundy reopened this Jan 11, 2023
@bergundy

Copy link
Copy Markdown
Member Author

@cretz CI seems unstable, I've had 3 consecutive unrelated failures.
Do you want to force merge?

@cretz

cretz commented Jan 11, 2023 •

Copy link
Copy Markdown
Contributor

This is failing on the time-skipping test server in CI (note the arm builds passed) so I suspect it's due to new RC release. For some reason it got an activity timeout immediately which makes me concerned that the test server isn't properly shutting off time skipping during activity invocation anymore? Or some other bug.

I have restarted CI since you've pinned the test server back to an older version and it works now. We need to make sure that we run this Python test with the test server before unpinning/upgrading it on the CDN.

@bergundy
bergundy merged commit ddbb92f into temporalio:main Jan 12, 2023
@bergundy
bergundy deleted the features-repo-rename branch January 12, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants