Misaligned pointer exposure in <String as TensorType>::unpack

The source of unsoundness

Hi, we found an unsound implementation in unpack which could create a misaligned pointer:

Lines 900 to 903 in 62a3019

    
           fn unpack(data: &[u8], count: usize) -> Result<Vec<Self>> { 
        
               let tstrings = 
        
                   unsafe { slice::from_raw_parts(data.as_ptr() as *const tf::TF_TString, count) }; 
        
               let mut out = Vec::with_capacity(count);

At line 902, the u8 pointer would cast to TF_TString which had stronger alignment requirements. The misaligned pointer passed to slice::from_raw_parts would break the safety guarantee. Please check and happy to have a discussion:)

It's not released yet, but as of #418 the TensorType trait is sealed. I'd like to follow up by marking that function as unsafe and hiding it from the docs. It's not intended to be called by client code, and in the code path that uses it internally it simply uses data from the C FFI, which is presumably aligned.

Navigation Menu

Repository navigation

Misaligned pointer exposure in `<String as TensorType>::unpack` #416

The source of unsoundness

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	fn unpack(data: &[u8], count: usize) -> Result<Vec<Self>> {
	let tstrings =
	unsafe { slice::from_raw_parts(data.as_ptr() as *const tf::TF_TString, count) };
	let mut out = Vec::with_capacity(count);

Misaligned pointer exposure in <String as TensorType>::unpack #416

Description

The source of unsoundness

Activity

adamcrume commented on Mar 13, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Misaligned pointer exposure in `<String as TensorType>::unpack` #416