TestcontainersExtension should be public to allow ordering extension in JUnit5

When we use multiple JUnit5 extensions, the way to order them is via the @ExtendsWith({FirstExtension.class, SecondExtension.class}) annotation.
But TestcontainersExtension is not public so we can only use the @Testcontainers annotion and we are not able to order the extension.

See the following documentation on JUnit5: https://junit.org/junit5/docs/current/user-guide/#extensions-registration-declarative

Some microservices frameworks have extension to start the application for integration testing, whe using test containers, we need to be sure that the testcontainers extension run first to start the containers before the apps starts.

I am not sure but maybe have a look at the @RegisterExtension Junit5 Annotation. It allows you to specifiy any Order.

here: https://junit.org/junit5/docs/current/user-guide/#extensions-registration-programmatic

I also need some setup like the registry authentication config and therefore just place the @ExtendsWith before the @Testcontainers Annotation at top level class.

HTH

@HaMatthias

@HaMatthias surely I can use @RegisterExtension instead of @ExtendsWith, but in both cases the TestContainersExtension needs to be public in order to use them.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@HaMatthias

@HaMatthias @bedla send a PR for this. I still think it is useful ...

Make TestcontainersExtension public

@loicmathieu

@loicmathieu @HaMatthias please see the discussion here: #5285

If you have any concrete examples of what you're looking for, that would be helpful!

@hmatt1

@hmatt1 I thought I clearly describe the use case: having the ability to order JUnit extensions used together on the same test case. The documented way to do this from the JUnit guide is to use @ExtendsWith({FirstExtension.class, SecondExtension.class}) which is not possible as the TestcontainersExtension is not public.

If you have any concrete examples of what you're looking for, that would be helpful!

I just want it to be public to be able to manage extensions order as it is intended.

@loicmathieu

@loicmathieu thanks for the quick response!

Which other extensions are you using that require ordering?

I opened a PR for this change, but the reviewer is considered not merging it because someone from JUnit recommended that it is not a good practice to require ordering between extensions. They were wondering if there was another solution to whatever problem you're trying to solve with the order of extensions.

Having testcontainer containers starts before my Quarkus test.

Even if JUnit didn't recommend to order between extensions, we sometimes needs to do it, and as testcontainers purpose is to launch dependencies as containers, it is very frequent that we need to start it before other extensions.

I also ran into this and wanted to support ordering so that @Testcontainers was started before @MicronautTest.

@loicmathieu

Hey @loicmathieu, thanks for responding. We were looking for a concrete example, rather than @ExtendsWith({FooExtension.class, BarExtension.class}), since this is rarely useful for understanding an actual use case (it will only lead to adding more generic capabilities to a framework).

With special regards to the JUnit5 extension, overusing can lead to a widespread usage of container-per-class or container-per-method, which is generally considered an anti-pattern by the Testcontainers community. So we are careful to add features to the library, that make it even easier to fall into this anti-pattern. Therefore, we really want to understand the actual use case and context.

@tburch This is a good example, thank you. When looking at the Micronaut docs (https://guides.micronaut.io/latest/micronaut-kafka-gradle-groovy.html) I can see that when using @MicronautTest in a Spock test, usage of @Testcontainers is not required and Micronaut instruments the containers accordingly. I wonder why this is not the case for the JUnit5 test and maybe this is something that should be considered in the @MicronautTest JUnit5 extension.

I find the integration with microservice frameworks especially interesting and an important topic to discuss, since e.g. @SpringBootTest integration with Testcontainers via @DynamicPropertySource does not require any order whatsoever. A further example of what makes me conscious to understand what the use case for manually controlling the order is and whether opening up is the right approach.

It's interesting that @DynamicPropertySource doesn't require any order. With Micronaut, I've been implementing TestPropertyProvider, which is order-dependent because I need the address/port from the container to set the properties correctly (for now manually starting the test container(s) prior to @MicronautTest doing its thing).

@kiview

@kiview I have an example that is not ordering related. I need to be able to enable/disable the extension based on a condition in our CI pipeline. Because the class is not public, I can't do it. See the end of this JUnit thread for their examples: junit-team/junit-framework#1242

abstract class MyBaseTest {
    companion object {
        @JvmField
        @RegisterExtension
        val someExtension = if (someCondition) {
            TestcontainersExtension()
        } else {
            DoNothingExtension()
        }      
    }
}

@drennerpfc6 Can you please elaborate on why using @Testcontainers(disabledWithoutDocker = true) is not sufficient for your use case?

@kiview

@kiview because I don't want the test disabled.

How do you provide the integration test dependencies in the other case? And what is the condition of the CI pipeline? Sorry, but we have to understand the actual use case context in order to make informed decisions on this.

@kiview

@kiview we simply run against real environments for regressions and the hope is to also run the same set of tests against testcontainers more frequently throughout the day. If I have to just manage the container lifecycle myself then I'll just do that but it's annoying.

Many other test frameworks expose their extension class so my hope was that it would be something you were open to changing.

I am not fundamentally against exposing them, just want to understand the use case and ideally avoid making falling into bad practices easier.

In the case of your example, I'd assume if you run against the real environment, you will run against the same infrastructure processes for the entirety of the test suite execution, correct? To correctly model this behavior, you should indeed not use any of the test framework integrations, but instead fallback to using the Singleton Container Pattern (which unfortunately has no direct support in the test framework extensions, because of current lack of integration points for such behavior). This approach will bind the lifecycle of the container to the JVM process lifecycle, which to me sounds much more similar to your conditional fallback and should therefore be preferred.

@kiview

@kiview that's what I'm working through right now. If it works then I guess I'll write my own extension to mange this since I do not want to duplicate code across 100+ applications.

What do you want to manage? Bind the container to the test-suite lifecycle instead of the test-class lifecycle? I am not completely up-to-date on any progress on the JUnit5 side of things around this topic, but issues like this suggest to me, that exactly this topic is still WIP: junit-team/junit-framework#2816

I do not want to duplicate code across 100+ applications.

Wouldn't you need to duplicate the conditional extension registry code you shared above across your applications as well?

@kiview

@kiview the only thing I want is to be able to disable testcontainers and not disable the actual tests based on some condition. Duplicating an if () statement is not a problem, I didn't want to duplicate the reset of it.

Thanks for everyone providing valuable feedback and context on their use cases. We decided to make the extension public, to give more freedom to our users, on how to use and integrate Testcontainers.

The change is merged in #5285.

Navigation Menu

Repository navigation

TestcontainersExtension should be public to allow ordering extension in JUnit5 #2045

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

TestcontainersExtension should be public to allow ordering extension in JUnit5 #2045

Description

Activity

HaMatthias commented on Nov 13, 2019

loicmathieu commented on Nov 14, 2019

stale commented on Feb 12, 2020

loicmathieu commented on Feb 12, 2020

hmatt1 commented on Jul 7, 2022

loicmathieu commented on Jul 8, 2022

hmatt1 commented on Jul 8, 2022

loicmathieu commented on Jul 8, 2022

tburch commented on Jul 8, 2022

kiview commented on Jul 11, 2022

tburch commented on Jul 11, 2022

superdrenner commented on Aug 12, 2022

kiview commented on Aug 15, 2022

superdrenner commented on Aug 15, 2022

kiview commented on Aug 15, 2022

superdrenner commented on Aug 15, 2022

kiview commented on Aug 15, 2022

superdrenner commented on Aug 15, 2022

kiview commented on Aug 15, 2022

superdrenner commented on Aug 15, 2022

kiview commented on Aug 16, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions