Skip to content

Documentation not displaying properly for 'Docker wormhole pattern' #4656

Closed

Description

@wimdeblauwe

The documentation at https://www.testcontainers.org/supported_docker_environment/continuous_integration/dind_patterns/ looks like this:

image

I assume the issue is that there needs to be an extra newline at https://github.com/testcontainers/testcontainers-java/blob/master/docs/supported_docker_environment/continuous_integration/dind_patterns.md?plain=1#L30

So this:

Where:
* `-v $PWD:$PWD` will add your current directory as a volume inside the container
* `-w $PWD` will set the current directory to this volume
* `-v /var/run/docker.sock:/var/run/docker.sock` will map the Docker socket

becomes:

Where:

* `-v $PWD:$PWD` will add your current directory as a volume inside the container
* `-w $PWD` will set the current directory to this volume
* `-v /var/run/docker.sock:/var/run/docker.sock` will map the Docker socket

Activity

  1. kiview commented on Nov 2, 2021

    @kiview
    Member

    Oh, you are right @wimdeblauwe, thanks for notifying us. Wonder why it happens since the GitHub markdown preview looks correct, but might be specifics of mkdocs.

    Do you want to provide the PR? 🙂

  2. added a commit that references this issue on Nov 2, 2021
    5413bdd
  3. wimdeblauwe commented on Nov 2, 2021

    @wimdeblauwe
    ContributorAuthor

    See #4658 for PR

  4. added this to the next milestone on Nov 2, 2021
  5. added a commit that references this issue on Nov 2, 2021
    d696024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions