Add module for Hashicorp Consul #4860

Activity

1. krisiye

   changed the title [-]Add Testcontainer for Hashicorp Consul[/-] [+]Add Testcontainer module for Hashicorp Consul[/+] on Jan 7, 2022
2. krisiye

   changed the title [-]Add Testcontainer module for Hashicorp Consul[/-] [+]Add module for Hashicorp Consul[/+] on Jan 7, 2022
3. kiview commented on Jan 10, 2022

   

   kiview

   on Jan 10, 2022

   Member

   More actions

   Hi @krisiye, are you raising this issue to ask if you should provide a PR with such a module?
4. krisiye commented on Jan 10, 2022

   

   krisiye

   on Jan 10, 2022

   Last edited by krisiye

   Author

   More actions

   @kiview - I'd be happy to contribute to a module. I have been using internal repos to provide containers for my purposes but i think hashicorp consul deserves to be a managed module that can exist alongside vault and iterate along. Let me know if that makes sense and i can work on a PR.
5. kiview commented on Jan 10, 2022

   

   kiview

   on Jan 10, 2022

   Member

   More actions

   Can you share your current solution, so we can better assess if the implementation of a distinct module makes sense?

   👍React with 👍1Reacted by Kris Iyer
6. krisiye commented on Jan 10, 2022

   

   krisiye

   on Jan 10, 2022

   Last edited by krisiye

   Author

   More actions

   @kiview - Here is a module I pushed out to my fork for your review - master...krisiye:issue_4860 thanks!
7. kiview commented on Jan 11, 2022

   

   kiview

   on Jan 11, 2022

   Member

   More actions

   Thanks a lot for sharing @krisiye. On a first look, your implementation seems fine.

   Since we are currently rethinking our approach to 3rd party modules, I'd suggest for now you publish the module yourself (e.g. like the Keycloak module: https://github.com/dasniko/testcontainers-keycloak) and we revisit this topic in the future (to ensure ongoing discoverability and compatibility).

   👍React with 👍1Reacted by Kris Iyer
8. krisiye commented on Jan 11, 2022

   

   krisiye

   on Jan 11, 2022

   Author

   More actions

   Thanks for the feedback @kiview! I will publish a module on my end. Regards!

   👍React with 👍1Reacted by Kevin Wittek
9. kiview

   added

   resolution/somedaymaybe

   type/new module

   on Jan 11, 2022
10. krisiye commented on Jan 26, 2022

    

    krisiye

    on Jan 26, 2022

    Last edited by krisiye

    Author

    More actions

    FYI - testcontainers-consul has been published.

    <dependency>
      <groupId>com.hmhco</groupId>
      <artifactId>testcontainers-consul</artifactId>
      <version>0.0.4</version>
      <scope>test</scope>
    </dependency>
    

    👍React with 👍2Reacted by Sergei Egorov and Kevin Wittek

    🚀React with 🚀2Reacted by Sergei Egorov and Kevin Wittek
11. kiview commented on Jan 27, 2022

    

    kiview

    on Jan 27, 2022

    Member

    More actions

    Thanks a lot @krisiye! 🙇‍♂️

    To everyone finding this issue, we strongly encourage you to try out and use https://github.com/hmhco/testcontainers-consul for the time being 🙂

    👍React with 👍1Reacted by Kris Iyer
12. eddumelendez commented on Aug 31, 2022

    

    eddumelendez

    on Aug 31, 2022

    Member

    More actions

    We already merged #4683 and it will be available in the next release and there is also com.hmhco:testcontainers-consul
13. eddumelendez

    closed this as completedon Aug 31, 2022