You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Enhancement]: Make ClickHouseContainer try to use new driver by default #6232
In #5474, support of the new com.clickhouse.jdbc.ClickHouseDriver was added. However, the implementation (the getDriverClassName() function) tries to load the older (deprecated) driver first, and the current Clickhouse JDBC distribution still (as of current version at the moment, 0.3.2-patch11) includes the older driver, so the newer one is actually never used.
I believe that the getDriverClassName() should behave the other way round: first try to load the new driver and, if it's not found, fall back to the old one. This was already noticed by user pan3793 but it seems that the comment was ignored.
Activity
eddumelendez commentedon Nov 24, 2022
@trolley813 Look at this PR. I am closing this and follow the conversation over there.