[Feature]: Presto Module uses the outdated Docker Image of `ghcr.io/trinodb/presto` and needs to be updated to `prestodb/presto`

[linghengqian]

Module

Presto

Problem

• Presto Module uses the outdated Docker Image of ghcr.io/trinodb/presto and needs to be updated to prestodb/presto.

• Refer to https://github.com/testcontainers/testcontainers-java/blob/1.19.8/modules/presto/src/main/java/org/testcontainers/containers/PrestoContainer.java and https://github.com/orgs/trinodb/packages/container/package/presto . ghcr.io/trinodb/presto has not been updated in 3 years.

• I'm confused by the instructions at https://java.testcontainers.org/modules/databases/presto/ .

This module is deprecated, use Trino module.

• The problem is, development of presto has been active, see https://hub.docker.com/r/prestodb/presto and https://github.com/prestodb/presto .

Solution

• Use prestodb/presto instead of ghcr.io/trinodb/presto in org.testcontainers.containers.PrestoContainer.

Benefit

• This would obviously clarify the current situation regarding Presto. Presto is still maintained normally, so the corresponding testcontainers module should not be marked as deprecated.

Alternatives

• Maybe not. I'm not sure why ghcr.io/trinodb/presto was used initially.

Would you like to help contributing this feature?

No

[eddumelendez]

Thanks for raising the issue, @linghengqian! But, IIRC it can be related to the move from Presto to Trino years ago.

Following with what you describe I've found deploy-docker doc and it seems the existing container implementation is missing. Also, when just switching to prestodb/presto image I got Query failed (#20240628_211923_00000_snga6): Catalog does not exist: memory. So, I think we need memory configuration.

I don't think I am the right person to do those changes. But, PRs are welcome from the ones with Presto knowledge.

[linghengqian]

Thanks for raising the issue, @linghengqian! But, IIRC it can be related to the move from Presto to Trino years ago.

Following with what you describe I've found deploy-docker doc and it seems the existing container implementation is missing. Also, when just switching to prestodb/presto image I got Query failed (#20240628_211923_00000_snga6): Catalog does not exist: memory. So, I think we need memory configuration.

I don't think I am the right person to do those changes. But, PRs are welcome from the ones with Presto knowledge.

• I opened Change the Docker Image used by the Presto module to prestodb/presto #8946 . There are quite a few differences between presto and trino involved.

[abhayshukla96]

Hi, I'd like to work on this issue. I'll update the Docker image reference from ghcr.io/trinodb/presto to prestodb/presto. Please assign it to me

[eddumelendez]

Thanks for the offer @abhayshukla96. But, please check the comments, there is already a PR that has been holding due to test failures. I saw the lastest message and will test it when have time.