Repository navigation
Fix ScriptUtils.runInitScript() in hierarchical classloader setup by using TCCL - #5167
Merged
Merged
Conversation
Contributor
Author
|
FYI @stuartwdouglas @geoand 🔝 |
Contributor
|
👌 |
famod
force-pushed
the
scriptutils-classloading
branch
from
March 9, 2022 16:52
a398517 to
7c70eda
Compare
Contributor
Author
Member
|
@famod Thanks for the ping, we'll have a look at it 🙂 |
Member
|
@famod Can you please explain how to reproduce the issue with Quarkus continuous testing, or share a reproducer? |
Member
|
I don't think we need Quarkus to test this, just a simple test should be added to the PR that ensures that the code takes context's classloader into the consideration 👍 |
Contributor
Author
|
I'll have a look. As I have a lot on my plate: Is there any ETA for the next TC release? |
Member
|
@famod We are currently in the process of preparing the next release. So having the test could help with getting this PR into the upcoming release. |
kiview
approved these changes
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes e.g.
MariaDBContainer.withInitScript(...)in Quarkus continuous testing, which is using a hierarchical classloading setup.Btw, for comparison,
MountableFile(e.g.MariaDBContainer.withConfigurationOverride(...)) does work already:testcontainers-java/core/src/main/java/org/testcontainers/utility/MountableFile.java
Line 128 in 14eff07