Repository navigation
Apply spotless and checkstyle - #5390
Merged
Merged
Conversation
eddumelendez
commented
May 20, 2022
Member
- Apply spotless and checkstyle
- Add preCommit
bsideup
reviewed
May 20, 2022
| dependencies { | ||
| // https://github.com/melix/japicmp-gradle-plugin/issues/36 | ||
| classpath 'com.google.guava:guava:30.1.1-jre' | ||
| classpath 'com.github.kiview:captain-hook:76a1c11a16' |
Member
Author
There was a problem hiding this comment.
to make it work with windows I guess https://github.com/kiview/captain-hook/commits/master
Member
There was a problem hiding this comment.
Exactly, PR was never merged in upstream, since upstream seems to be dead 😞
tjni/captain-hook#4
bsideup
reviewed
May 20, 2022
bsideup
reviewed
May 20, 2022
bsideup
reviewed
May 20, 2022
This reverts commit 171bba2.
bsideup
reviewed
May 21, 2022
bsideup
reviewed
May 21, 2022
Member
Author
|
the |
kiview
reviewed
May 23, 2022
kiview
reviewed
May 23, 2022
Comment on lines
+14
to
+15
| @Language("groovy") | ||
| String myTest = """ |
Member
There was a problem hiding this comment.
Those lines should be aligned. But if it is hard to configure, we can live with that.
kiview
reviewed
May 23, 2022
bsideup
reviewed
May 25, 2022
bsideup
reviewed
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.