Skip to content

Don't ignore sql test query exception, add it as cause exception #5484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kiview merged 2 commits into from
Jun 13, 2022
Merged

Don't ignore sql test query exception, add it as cause exception #5484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1000f8
Don't ignore sql test query exception, add it as cause exception
anatoly0karyakin Jun 11, 2022
f624adb
fix code formatting
anatoly0karyakin Jun 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ protected void waitUntilContainerStarted() {
// Repeatedly try and open a connection to the DB and execute a test query
long start = System.currentTimeMillis();

Exception lastConnectionException = null;
while (System.currentTimeMillis() < start + (1000 * startupTimeoutSeconds)) {
if (!isRunning()) {
Thread.sleep(100L);
Expand All @@ -165,6 +166,7 @@ protected void waitUntilContainerStarted() {
// we explicitly want this exception to fail fast without retries
throw e;
} catch (Exception e) {
lastConnectionException = e;
// ignore so that we can try again
logger().debug("Failure when trying test query", e);
Thread.sleep(100L);
Expand All @@ -176,7 +178,8 @@ protected void waitUntilContainerStarted() {
String.format(
"Container is started, but cannot be accessed by (JDBC URL: %s), please check container logs",
this.getJdbcUrl()
)
),
lastConnectionException
);
}

Expand Down