Skip to content

Enforce UTF-8 as Javadoc encoding - #5738

Merged
kiview merged 2 commits into
testcontainers:masterfrom
gesellix:windows
Aug 18, 2022
Merged

kiview merged 2 commits into
testcontainers:masterfrom
gesellix:windows

Conversation

@gesellix

@gesellix gesellix commented Aug 17, 2022 •

Copy link
Copy Markdown
Contributor

The Javadoc task (or publishing) fails when running on Windows with "unmappable character for encoding Cp1252" at

The patch includes a version change for the com.gradle.common-custom-user-data-gradle-plugin, too, because 1.8.0 can't be found.

@kiview

kiview commented Aug 18, 2022 •

Copy link
Copy Markdown
Member

The 1.8.0 issue is so weird, wonder how this happened.

Edit:
Oh, this came in through a dependabot merge, very strange it was not caught on CI before.

@gesellix

Copy link
Copy Markdown
Contributor Author

Yeah, I'm also confused and maybe the cause is somewhere at jcenter 🤷

@kiview
kiview merged commit 1830464 into testcontainers:master Aug 18, 2022
@kiview

kiview commented Aug 18, 2022

Copy link
Copy Markdown
Member

Thanks, @gesellix and thanks for fixing master 🙇

@kiview kiview added this to the next milestone Aug 18, 2022
@gesellix
gesellix deleted the windows branch August 18, 2022 13:53
@kiview

kiview commented Aug 18, 2022

Copy link
Copy Markdown
Member

@gesellix FYI I just talked with some folks at Gradle and indeed, there used to be a 1.8.0 version, that was republished as 1.8 yesterday, so that explains it. Thanks for helping out on this 😇

@gesellix

Copy link
Copy Markdown
Contributor Author

Sure thing (no one wants a broken master 😉) and thanks for the update @kiview !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants